From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D88BFC43334 for ; Fri, 1 Jul 2022 19:34:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230269AbiGATes (ORCPT ); Fri, 1 Jul 2022 15:34:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbiGATeq (ORCPT ); Fri, 1 Jul 2022 15:34:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 514F71BE84 for ; Fri, 1 Jul 2022 12:34:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E247662101 for ; Fri, 1 Jul 2022 19:34:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10AE7C3411E; Fri, 1 Jul 2022 19:34:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656704084; bh=dEu/u9dgfs1RHHkM0fkOgtAUXU1kmpj5LCeuGMQMttI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jdzO9DswH3WCzTLver5Ukfwgcu1y3kEayD2Udew/YpxLqyMuG4k2AmOajMU5ZhEdr 4DPH8fYP89C473mASb73jj2AGtVbyT+65zfdfVZIN+zQPw5pNL50WCxTc9e5gbiY7R diNX+0lYiYuAaDSJrj7OeFyNvWM4YJ6bDYn9j45g2P0NWEi45kswkf41xp3EoT8VRT ikHAgseGyuPYr+gGznoao+WcJDGN39lJCacnrzhVr2AcrlkYUP8A6IKP7sO5hZYzJ7 B0GzDZZiyWkoiJQhQeozynCH+I4ITfPubb1KENP352K5CjOGH6f1wrsi4vR1w0EvQQ rSSCigcEt6dpA== Date: Fri, 1 Jul 2022 21:34:35 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Belloni , "Alvin __ipraga" , Claudiu Manoil , "David S. Miller" , DENG Qingfang , Eric Dumazet , Florian Fainelli , George McCollister , Hauke Mehrtens , Jakub Kicinski , Kurt Kanzenbach , Landen Chao , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , Sean Wang , UNGLinuxDriver@microchip.com, Vivien Didelot , Vladimir Oltean , Woojung Huh Subject: Re: [PATCH RFC net-next 5/6] net: dsa: always use phylink for CPU and DSA ports Message-ID: <20220701213435.53ecdd70@thinkpad> In-Reply-To: References: X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 29 Jun 2022 13:51:43 +0100 "Russell King (Oracle)" wrote: > Currently, we only use phylink for CPU and DSA ports if there is a > fixed-link specification, or a PHY specified. The reason for this > behaviour is that when neither is specified, there was no way for > phylink to know the link parameters. >=20 > Now that we have phylink_set_max_link_speed() (which has become > possible through the addition of mac_capabilities) we now have the > ability to know the maximum link speed for a specific link, and can > now use phylink for this case as well. >=20 > However, we need DSA drivers to report the interface mode being used > on these ports so that we can select a maximum speed appropriate for > the interface mode that hardware may have configured for the port. >=20 > This is especially important with the conversion of DSA drivers to > phylink_pcs, as the PCS code only gets called if we are using > phylink for the port. >=20 > Signed-off-by: Russell King (Oracle) Reviewed-by: Marek Beh=C3=BAn So this is the one that may break other drivers? Marek