Re: [PATCH net-next v3 5/7] net: lan966x: Add lag support for lan966x.

kernel test robot
2022-07-05T18:38:57Z

Hi Horatiu,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url: https://github.com/intel-lab-lkp/linux/commits/Horatiu-Vultur/net-lan966x-Add-lag-support/20220702-045154
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dbdd9a28e1406ab8218a69e60f10a168b968c81d
config: powerpc-randconfig-r012-20220703 (https://download.01.org/0day-ci/archive/20220706/202207060247.0TIpleTV-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/a531636c4ccc3d4528016f83627b2e4677e83e59
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Horatiu-Vultur/net-lan966x-Add-lag-support/20220702-045154
git checkout a531636c4ccc3d4528016f83627b2e4677e83e59
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

powerpc-linux-ld: drivers/net/ethernet/microchip/lan966x/lan966x_lag.o: in function `lan966x_lag_port_join':
>> drivers/net/ethernet/microchip/lan966x/lan966x_lag.c:138: undefined reference to `br_port_get_stp_state'

vim +138 drivers/net/ethernet/microchip/lan966x/lan966x_lag.c

118
119 int lan966x_lag_port_join(struct lan966x_port *port,
120 struct net_device *brport_dev,
121 struct net_device *bond,
122 struct netlink_ext_ack *extack)
123 {
124 struct lan966x *lan966x = port->lan966x;
125 struct net_device *dev = port->dev;
126 int err;
127
128 port->bond = bond;
129 lan966x_lag_update_ids(lan966x);
130
131 err = switchdev_bridge_port_offload(brport_dev, dev, port,
132 &lan966x_switchdev_nb,
133 &lan966x_switchdev_blocking_nb,
134 false, extack);
135 if (err)
136 goto out;
137
> 138 lan966x_port_stp_state_set(port, br_port_get_stp_state(brport_dev));
139
140 return 0;
141
142 out:
143 port->bond = NULL;
144 lan966x_lag_update_ids(lan966x);
145
146 return err;
147 }
148

--
0-DAY CI Kernel Test Service