From: Mathew McBride <matt@traverse.com.au>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org, Mathew McBride <matt@traverse.com.au>
Subject: [PATCH ethtool 2/2] ethtool: remove restriction on ioctl commands having JSON output
Date: Mon, 4 Jul 2022 05:41:14 +0000 [thread overview]
Message-ID: <20220704054114.22582-3-matt@traverse.com.au> (raw)
In-Reply-To: <20220704054114.22582-1-matt@traverse.com.au>
The module-info/dump eeprom (-m/--module-info) is one such command
which is now able to produce JSON.
Signed-off-by: Mathew McBride <matt@traverse.com.au>
---
ethtool.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/ethtool.c b/ethtool.c
index 83bbde8..ece4ac0 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -6409,9 +6409,6 @@ int main(int argc, char **argp)
ctx.argp = argp;
netlink_run_handler(&ctx, args[k].nlchk, args[k].nlfunc, !args[k].func);
- if (ctx.json) /* no IOCTL command supports JSON output */
- exit_bad_args();
-
ret = ioctl_init(&ctx, args[k].no_dev);
if (ret)
return ret;
--
2.30.1
next prev parent reply other threads:[~2022-07-04 5:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 5:41 [PATCH ethtool 0/2] Add JSON support for SFP EEPROM dump Mathew McBride
2022-07-04 5:41 ` [PATCH ethtool 1/2] ethtool: add JSON output to --module-info Mathew McBride
2022-10-06 15:29 ` Michal Kubecek
2022-07-04 5:41 ` Mathew McBride [this message]
2022-10-06 15:23 ` [PATCH ethtool 2/2] ethtool: remove restriction on ioctl commands having JSON output Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220704054114.22582-3-matt@traverse.com.au \
--to=matt@traverse.com.au \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).