From: Jakub Kicinski <kuba@kernel.org>
To: Leonard Crestez <cdleonard@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Soheil Hassas Yeganeh <soheil@google.com>,
Wei Wang <weiwan@google.com>,
Joanne Koong <joannelkoong@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: Shrink sock.sk_err sk_err_soft to u16 from int
Date: Tue, 5 Jul 2022 12:06:00 -0700 [thread overview]
Message-ID: <20220705120600.4ea241d5@kernel.org> (raw)
In-Reply-To: <74c6f54cd3869258f4c83b46d9e5b95f7f0dab4b.1656878516.git.cdleonard@gmail.com>
On Sun, 3 Jul 2022 23:06:43 +0300 Leonard Crestez wrote:
> - int sk_err,
> + u16 sk_err,
> sk_err_soft;
While at it please remove the comma and explicitly type both fields.
BTW are there are no architectures of note which can't load 2B entities,
any more? Historically 16b is an awkward quantity for RISC arches.
next prev parent reply other threads:[~2022-07-05 19:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-03 20:06 [PATCH] net: Shrink sock.sk_err sk_err_soft to u16 from int Leonard Crestez
2022-07-05 10:31 ` Paolo Abeni
2022-07-05 13:01 ` Leonard Crestez
2022-07-05 22:26 ` Soheil Hassas Yeganeh
2022-07-05 19:06 ` Jakub Kicinski [this message]
2022-07-06 14:04 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705120600.4ea241d5@kernel.org \
--to=kuba@kernel.org \
--cc=cdleonard@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joannelkoong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=soheil@google.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).