From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48DD6C433EF for ; Tue, 5 Jul 2022 19:23:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230417AbiGETXo (ORCPT ); Tue, 5 Jul 2022 15:23:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230078AbiGETXn (ORCPT ); Tue, 5 Jul 2022 15:23:43 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 804FC13CF7 for ; Tue, 5 Jul 2022 12:23:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D44F9CE1CE8 for ; Tue, 5 Jul 2022 19:23:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06991C341C7; Tue, 5 Jul 2022 19:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657049019; bh=a1QhGobGGck9fYK28TfvF/uBRmQzx1mW8fvLYxe7ud0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gCVkUbFeAepDHcZsbfREmK1yh2KbFXj1P+6YG1aOQRHwnYqpdrsw/0/UwYnJgVtLw yGWX/WHg1aQhq9OElUCBkIFngU0x8PMjsWRQuyB8X6RuuofA5z17Dl++FXq8CklpDV TDTChte3NF3x7MzbuvK4aJAZPLuIcCZpw9V2hreP2HEW6LUbknwYLqAnzgXPxGOc0V kq8Tp1bSHhRuXQUnGJF73UMeeSuD8IDedstZclwrBJywqrLJuONkO/ESs4sTiguhel BdiezL2J78OpY9C96b9CEq7HWNxYO+FyG1YLJ+oGguKys+QtXb1l8NZmaZ3eLVucPI hYaj+pKJPHkhQ== Date: Tue, 5 Jul 2022 12:23:37 -0700 From: Jakub Kicinski To: Heiner Kallweit Cc: Paolo Abeni , David Miller , Realtek linux nic maintainers , "netdev@vger.kernel.org" Subject: Re: [PATCH net] r8169: fix accessing unset transport header Message-ID: <20220705122337.696a6d78@kernel.org> In-Reply-To: <1ca36910-31c0-ead6-d19e-c200eff752b4@gmail.com> References: <1670430b92ef3cbda6647ce249a6bafb9d243432.camel@redhat.com> <20220705121230.69a4e0e8@kernel.org> <1ca36910-31c0-ead6-d19e-c200eff752b4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 5 Jul 2022 21:18:43 +0200 Heiner Kallweit wrote: > > How about we put Eric's patch under Fixes? The patch is not really > > needed unless the warning is there. > > This would also be an option. It just seemed a little illogical to me > to leave the impression a new (useful) warning needs to be fixed. > Just a few seconds ago I sent a v2 following Paolo's proposal. That's fine. Perhaps I have more utilitarian than literal view of the Fixes tag than others (how far back can the problem trigger vs blame).