From: Saeed Mahameed <saeedm@nvidia.com>
To: Vlad Buslov <vladbu@nvidia.com>
Cc: davem@davemloft.net, kuba@kernel.org, jianbol@nvidia.com,
idosch@nvidia.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com,
jiri@resnulli.us, netdev@vger.kernel.org, maord@nvidia.com
Subject: Re: [PATCH net 2/2] net/mlx5e: Fix matchall police parameters validation
Date: Tue, 5 Jul 2022 22:45:04 -0700 [thread overview]
Message-ID: <20220706054504.q4vz7gpqdk7udajf@sx1> (raw)
In-Reply-To: <20220704204405.2563457-3-vladbu@nvidia.com>
On 04 Jul 22:44, Vlad Buslov wrote:
>Referenced commit prepared the code for upcoming extension that allows mlx5
>to offload police action attached to flower classifier. However, with
>regard to existing matchall classifier offload validation should be
>reversed as FLOW_ACTION_CONTINUE is the only supported notexceed police
>action type. Fix the problem by allowing FLOW_ACTION_CONTINUE for police
>action and extend scan_tc_matchall_fdb_actions() to only allow such actions
>with matchall classifier.
>
>Fixes: d97b4b105ce7 ("flow_offload: reject offload for all drivers with invalid police parameters")
>Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
Acked-by: Saeed Mahameed <saeedm@nvidia.com>
next prev parent reply other threads:[~2022-07-06 5:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 20:44 [PATCH net 0/2] Fix police 'continue' action offload Vlad Buslov
2022-07-04 20:44 ` [PATCH net 1/2] net/sched: act_police: allow " Vlad Buslov
2022-07-04 20:44 ` [PATCH net 2/2] net/mlx5e: Fix matchall police parameters validation Vlad Buslov
2022-07-06 5:45 ` Saeed Mahameed [this message]
2022-07-06 0:11 ` [PATCH net 0/2] Fix police 'continue' action offload Jakub Kicinski
2022-07-06 5:46 ` Saeed Mahameed
2022-07-06 9:57 ` Vlad Buslov
2022-07-07 9:33 ` Simon Horman
2022-07-06 11:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706054504.q4vz7gpqdk7udajf@sx1 \
--to=saeedm@nvidia.com \
--cc=davem@davemloft.net \
--cc=idosch@nvidia.com \
--cc=jhs@mojatatu.com \
--cc=jianbol@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=maord@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox