From: Jakub Kicinski <kuba@kernel.org>
To: "Liang He" <windhl@126.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] ftgmac100: Hold reference returned by of_get_child_by_name()
Date: Wed, 6 Jul 2022 09:34:59 -0700 [thread overview]
Message-ID: <20220706093459.2885de93@kernel.org> (raw)
In-Reply-To: <41ae7b8e.5fda.181d2b8d4ff.Coremail.windhl@126.com>
On Wed, 6 Jul 2022 16:55:37 +0800 (CST) Liang He wrote:
> >Since we don't care about the value of the node we should add a helper
> >which checks for presence of the node and releases the reference,
> >rather than have to do that in this large function.
> >
> >Please also add a Fixes tag.
>
> Hi, Jakub,
>
> Can you tell me where to add such helper?
>
> you mean add a helper in of.h for common usasge or just add it in this file?
I was wondering about that. Since this is a fix let's keep it simple
and add the helper directly in the same source file.
If you have more time to spend on this try searching around the tree to
see if there are more places where such helper would help. If there are
we can move the helper to of.h and convert the users in -next.
next prev parent reply other threads:[~2022-07-06 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 15:18 [PATCH] ftgmac100: Hold reference returned by of_get_child_by_name() Liang He
2022-07-06 1:48 ` Jakub Kicinski
2022-07-06 1:58 ` Liang He
2022-07-06 8:55 ` Liang He
2022-07-06 16:34 ` Jakub Kicinski [this message]
2022-07-07 1:28 ` Liang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706093459.2885de93@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).