From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E41A3C43334 for ; Wed, 6 Jul 2022 15:34:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234214AbiGFPeg (ORCPT ); Wed, 6 Jul 2022 11:34:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234082AbiGFPeM (ORCPT ); Wed, 6 Jul 2022 11:34:12 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47147286D9; Wed, 6 Jul 2022 08:32:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D4698B81D90; Wed, 6 Jul 2022 15:32:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39D21C341CD; Wed, 6 Jul 2022 15:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657121568; bh=tHbmYTk29C+tyConO9otde+kD25xesrNCWFelZW3mIY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SIN9ES7Xvc3T6U+ZuedU40DPONSPXFHjnLIudoNTIbZh8DMxtVLA/K+lIYY77NVzO knwE1K7bbtytntid8WrUv6K36hiqaNOVNcFybtsMDSPRyjEEuxqj03xFESlSN0fAm5 0yPvs8ZAC4lMbZ58jLFuyBDMXM4Mh5DSnGgFOPQ89XzLwd4xUVmeD0nz1S/fG2q7Au Xa1mGMaaQ1n+Y2vEb1v16Hgf+UvBSjt8Jpf7k128xpE5Q6XSfOdjzFqeJsenuTphst 9SzRSqHuKeA343YAqcgLB14Efjg7C6zzzfpDQ+s5IBiHZjfkIyQzLGdLA+GPcUyY59 8G7zTjm8BHBPw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hangyu Hua , Tung Nguyen , "David S . Miller" , Sasha Levin , jmaloy@redhat.com, ying.xue@windriver.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net Subject: [PATCH AUTOSEL 5.15 14/18] net: tipc: fix possible refcount leak in tipc_sk_create() Date: Wed, 6 Jul 2022 11:31:49 -0400 Message-Id: <20220706153153.1598076-14-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220706153153.1598076-1-sashal@kernel.org> References: <20220706153153.1598076-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Hangyu Hua [ Upstream commit 00aff3590fc0a73bddd3b743863c14e76fd35c0c ] Free sk in case tipc_sk_insert() fails. Signed-off-by: Hangyu Hua Reviewed-by: Tung Nguyen Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/tipc/socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 17f8c523e33b..43509c7e90fc 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -502,6 +502,7 @@ static int tipc_sk_create(struct net *net, struct socket *sock, sock_init_data(sock, sk); tipc_set_sk_state(sk, TIPC_OPEN); if (tipc_sk_insert(tsk)) { + sk_free(sk); pr_warn("Socket create failed; port number exhausted\n"); return -EINVAL; } -- 2.35.1