From: Jakub Kicinski <kuba@kernel.org>
To: Duoming Zhou <duoming@zju.edu.cn>
Cc: linux-hams@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ralf@linux-mips.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net v2] net: rose: fix UAF bug caused by rose_t0timer_expiry
Date: Wed, 6 Jul 2022 19:02:37 -0700 [thread overview]
Message-ID: <20220706190237.477f24ee@kernel.org> (raw)
In-Reply-To: <20220705125610.77971-1-duoming@zju.edu.cn>
On Tue, 5 Jul 2022 20:56:10 +0800 Duoming Zhou wrote:
> + del_timer_sync(&rose_neigh->t0timer);
/**
* del_timer_sync - deactivate a timer and wait for the handler to finish.
[...]
* Synchronization rules: Callers must prevent restarting of the timer,
* otherwise this function is meaningless.
how is the restarting prevented? If I'm looking right
rose_t0timer_expiry() rearms the timer.
next prev parent reply other threads:[~2022-07-07 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 12:56 [PATCH net v2] net: rose: fix UAF bug caused by rose_t0timer_expiry Duoming Zhou
2022-07-07 2:02 ` Jakub Kicinski [this message]
2022-07-07 2:23 ` duoming
2022-07-07 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706190237.477f24ee@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=duoming@zju.edu.cn \
--cc=edumazet@google.com \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).