From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFED4C433EF for ; Thu, 7 Jul 2022 02:21:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229775AbiGGCVK (ORCPT ); Wed, 6 Jul 2022 22:21:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbiGGCVK (ORCPT ); Wed, 6 Jul 2022 22:21:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 753272F388 for ; Wed, 6 Jul 2022 19:21:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 194726208B for ; Thu, 7 Jul 2022 02:21:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24052C3411C; Thu, 7 Jul 2022 02:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657160468; bh=PRY5zsm5z6AYW868LPVwToiUp9mWmHQyJGi+aJsZTdo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GzVf5gGHL5dHQGXf240Lh/eDYQIRRlJIUVTnh4QOpuFqUXrOn7nWY5iwL8SrME7wO fjMsGf1v/9v6lJIjTqHKEUTGDGPCdKcnbOs+bpst/Z7xi9YRSaXGHA0/hGyPRHE9NB 5+sscI3tl5HC0Dd6XTsSvayxe+biBJ/9Lu8thu1GHcwahTz7ALMOWzWvrzbw7z/ex7 z/2cGmy6W7BlpLz970Zpqgln6qpDGII0W07xoMlWUcsLlHQl/6nj/tvjVPNl8wOOCg kmhiAYPK3iOrLuHxLq6CSjVxG6F7dpmKOAWlhKLihGdHgM1XB+GBMb2jhM1O7H7oth LZvRlDfEsZ5jg== Date: Wed, 6 Jul 2022 19:21:07 -0700 From: Jakub Kicinski To: Saeed Mahameed Cc: "David S. Miller" , Paolo Abeni , Eric Dumazet , Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Maxim Mikityanskiy Subject: Re: [net-next 10/15] net/tls: Perform immediate device ctx cleanup when possible Message-ID: <20220706192107.0b6fe869@kernel.org> In-Reply-To: <20220706232421.41269-11-saeed@kernel.org> References: <20220706232421.41269-1-saeed@kernel.org> <20220706232421.41269-11-saeed@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 6 Jul 2022 16:24:16 -0700 Saeed Mahameed wrote: > From: Tariq Toukan > > TLS context destructor can be run in atomic context. Cleanup operations > for device-offloaded contexts could require access and interaction with > the device callbacks, which might sleep. Hence, the cleanup of such > contexts must be deferred and completed inside an async work. > > For all others, this is not necessary, as cleanup is atomic. Invoke > cleanup immediately for them, avoiding queueuing redundant gc work. > > Signed-off-by: Tariq Toukan > Reviewed-by: Maxim Mikityanskiy > Signed-off-by: Saeed Mahameed Not sure if posting core patches as part of driver PRs is a good idea, if I ack this now the tag will not propagate.