Re: [PATCH v2 net-next 1/4] dt-bindings: net: convert sff,sfp to dtschema

[Ioana Ciornei <ioana.ciornei@nxp.com>]

On Tue, Jul 05, 2022 at 03:29:03PM -0600, Rob Herring wrote:
> On Mon, Jul 04, 2022 at 04:46:01PM +0300, Ioana Ciornei wrote:
> > Convert the sff,sfp.txt bindings to the DT schema format.
> > Also add the new path to the list of maintained files.
> > 
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> > ---
> > Changes in v2:
> >  - used the -gpios suffix
> >  - restricted the use of some gpios if the compatible is sff,sff
> > 
> >  .../devicetree/bindings/net/sff,sfp.txt       |  85 -----------
> >  .../devicetree/bindings/net/sff,sfp.yaml      | 143 ++++++++++++++++++
> >  MAINTAINERS                                   |   1 +
> >  3 files changed, 144 insertions(+), 85 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/net/sff,sfp.txt
> >  create mode 100644 Documentation/devicetree/bindings/net/sff,sfp.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/net/sff,sfp.txt b/Documentation/devicetree/bindings/net/sff,sfp.txt
> > deleted file mode 100644
> > index 832139919f20..000000000000
> > --- a/Documentation/devicetree/bindings/net/sff,sfp.txt
> > +++ /dev/null
> > @@ -1,85 +0,0 @@
> > -Small Form Factor (SFF) Committee Small Form-factor Pluggable (SFP)
> > -Transceiver

(...)

> > +  maximum-power-milliwatt:
> > +    maxItems: 1
> > +    description:
> > +      Maximum module power consumption Specifies the maximum power consumption
> > +      allowable by a module in the slot, in milli-Watts. Presently, modules can
> > +      be up to 1W, 1.5W or 2W.
> 
>        enum: [ 1000, 1500, 2000 ]
> 
> Or is it not just those values? Maybe 'maximum: 2000' instead.

Keeping in mind Russell's comment, I think I will leave this just as it
is since there is no enforcing made on the value.

> 
> > +
> > +patternProperties:
> > +  "mod-def0-gpios":
> 
> These aren't patterns. Move to 'properties'.

Yes, I forgot to move them when I removed the '(s)?'

Thanks!

Ioana