From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3810C43334 for ; Thu, 7 Jul 2022 16:15:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235989AbiGGQPU (ORCPT ); Thu, 7 Jul 2022 12:15:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236182AbiGGQPC (ORCPT ); Thu, 7 Jul 2022 12:15:02 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A20A28722 for ; Thu, 7 Jul 2022 09:14:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id B56E6CE25BB for ; Thu, 7 Jul 2022 16:14:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA0F3C341C0; Thu, 7 Jul 2022 16:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657210492; bh=MdQfPXULr8CxrfINbVlBzsn8fJnMUz9b1hhRq6f7FUU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kkcYylHxzIdDez3MXu2LXPamwWJr1cu4GAO0n76H3yl3dDed/bIFBgDT+Uq1QCu7K p1cBvXJvnMnR368eeJpetmqkIcl/MSR60UhGxR1E6SIQ4GcHVyd2EgJa3qsu1nPv1e /cIoKDxLoTfE6Iz5bNB7tzJ04pWa6X42O6yMXIsZZC4gwbgl3WkTnoF5NkGzjIdUot w6XekCXbawLeqkBbBhGUDItr6skxsWxSwPJ/2NH79nJQcpIqIFVkHBqtaqYPJVLkQq OqjRZFyJ67axDSCcaf/W1xExWiQc85DcVRb0yHg29emM4L9NKRcBFS0mzra3C79eGb Muu38YpFRvl5A== Date: Thu, 7 Jul 2022 09:14:42 -0700 From: Jakub Kicinski To: Saeed Mahameed Cc: "David S. Miller" , Paolo Abeni , Eric Dumazet , Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Maxim Mikityanskiy Subject: Re: [net-next 10/15] net/tls: Perform immediate device ctx cleanup when possible Message-ID: <20220707091442.01354da7@kernel.org> In-Reply-To: <20220707065114.4tdx6f2lxig6lsof@sx1> References: <20220706232421.41269-1-saeed@kernel.org> <20220706232421.41269-11-saeed@kernel.org> <20220706192107.0b6fe869@kernel.org> <20220707065114.4tdx6f2lxig6lsof@sx1> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 6 Jul 2022 23:51:14 -0700 Saeed Mahameed wrote: > On 06 Jul 19:21, Jakub Kicinski wrote: > >On Wed, 6 Jul 2022 16:24:16 -0700 Saeed Mahameed wrote: > >> From: Tariq Toukan > >> > >> TLS context destructor can be run in atomic context. Cleanup operations > >> for device-offloaded contexts could require access and interaction with > >> the device callbacks, which might sleep. Hence, the cleanup of such > >> contexts must be deferred and completed inside an async work. > >> > >> For all others, this is not necessary, as cleanup is atomic. Invoke > >> cleanup immediately for them, avoiding queueuing redundant gc work. > >> > >> Signed-off-by: Tariq Toukan > >> Reviewed-by: Maxim Mikityanskiy > >> Signed-off-by: Saeed Mahameed > > > >Not sure if posting core patches as part of driver PRs is a good idea, > >if I ack this now the tag will not propagate. > > I agree, how about the devlink lock removal ? same thing ? I didn't have the same reaction to the devlink part, perhaps because of the clear driver dependency there and the fact we discussed that work thoroughly before. Looking at it again it seems like the problem is that these are really two independent series squashed together, no? Multiple driver features mixed up in a series is fine but when changing the core let's stick to clearer separation. The objective is to get reviewers engaged, and it's really easy to miss the core changes among the driver ones in a large multi-purpose series. On the topic of PRs, does it matter to you if the core changes are posted as a PR? I presume it's okay for those to come out as a normal series with a proper subject and applied from the list?