From: Jakub Kicinski <kuba@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sgoutham@marvell.com>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>
Subject: Re: [net-next PATCH V3 06/12] octeontx2-af: Drop rules for NPC MCAM
Date: Thu, 7 Jul 2022 17:54:28 -0700 [thread overview]
Message-ID: <20220707175428.127006ba@kernel.org> (raw)
In-Reply-To: <20220707073353.2752279-7-rkannoth@marvell.com>
On Thu, 7 Jul 2022 13:03:47 +0530 Ratheesh Kannoth wrote:
> NPC exact match table installs drop on hit rules in
> NPC mcam for each channel. This rule has broadcast and multicast
> bits cleared. Exact match bit cleared and channel bits
> set. If exact match table hit bit is 0, corresponding NPC mcam
> drop rule will be hit for the packet and will be dropped.
kdoc:
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1462: warning: bad line: u8 cgx_id, lmac_id;
clang:
../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1228:6: warning: variable 'disable_cam' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (entry->cmd)
^~~~~~~~~~
../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1232:6: note: uninitialized use occurs here
if (disable_cam) {
^~~~~~~~~~~
../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1228:2: note: remove the 'if' if its condition is always true
if (entry->cmd)
^~~~~~~~~~~~~~~
../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1201:18: note: initialize the variable 'disable_cam' to silence this warning
bool disable_cam;
^
= 0
../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1308:6: warning: variable 'enable_cam' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (cmd)
^~~
../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1312:6: note: uninitialized use occurs here
if (enable_cam) {
^~~~~~~~~~
../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1308:2: note: remove the 'if' if its condition is always true
if (cmd)
^~~~~~~~
../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1275:17: note: initialize the variable 'enable_cam' to silence this warning
bool enable_cam;
^
= 0
next prev parent reply other threads:[~2022-07-08 0:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 7:33 [net-next PATCH V3 00/12] octeontx2: Exact Match Table Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 01/12] octeontx2-af: Use hashed field in MCAM key Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 02/12] octeontx2-af: Exact match support Ratheesh Kannoth
2022-07-08 0:53 ` Jakub Kicinski
2022-07-08 4:48 ` [EXT] " Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 03/12] octeontx2-af: Exact match scan from kex profile Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 04/12] octeontx2-af: devlink configuration support Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 05/12] octeontx2-af: FLR handler for exact match table Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 06/12] octeontx2-af: Drop rules for NPC MCAM Ratheesh Kannoth
2022-07-08 0:54 ` Jakub Kicinski [this message]
2022-07-08 4:45 ` [EXT] " Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 07/12] octeontx2-af: Debugsfs support for exact match Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 08/12] octeontx2: Modify mbox request and response structures Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 09/12] octeontx2-af: Wrapper functions for MAC addr add/del/update/reset Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 10/12] octeontx2-af: Invoke exact match functions if supported Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 11/12] octeontx2-pf: Add support for exact match table Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 12/12] octeontx2-af: Enable Exact match flag in kex profile Ratheesh Kannoth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220707175428.127006ba@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).