* [PATCH] iavf: Remove condition with no effect
@ 2022-07-08 3:51 Zhongjun Tan
2022-07-08 22:14 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Zhongjun Tan @ 2022-07-08 3:51 UTC (permalink / raw)
To: jesse.brandeburg, anthony.l.nguyen, davem, edumazet, kuba, pabeni,
intel-wired-lan
Cc: netdev, linux-kernel, Zhongjun Tan
From: Zhongjun Tan <tanzhongjun@coolpad.com>
Remove condition with no effect
Signed-off-by: Zhongjun Tan <tanzhongjun@coolpad.com>
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 69ade653f5d4..52b622ea7d6b 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -2136,8 +2136,6 @@ iavf_set_vlan_offload_features(struct iavf_adapter *adapter,
vlan_ethertype = ETH_P_8021Q;
else if (prev_features & (NETIF_F_HW_VLAN_STAG_RX | NETIF_F_HW_VLAN_STAG_TX))
vlan_ethertype = ETH_P_8021AD;
- else if (prev_features & (NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_CTAG_TX))
- vlan_ethertype = ETH_P_8021Q;
else
vlan_ethertype = ETH_P_8021Q;
--
2.29.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iavf: Remove condition with no effect
2022-07-08 3:51 [PATCH] iavf: Remove condition with no effect Zhongjun Tan
@ 2022-07-08 22:14 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-07-08 22:14 UTC (permalink / raw)
To: Zhongjun Tan
Cc: jesse.brandeburg, anthony.l.nguyen, davem, edumazet, pabeni,
intel-wired-lan, netdev, linux-kernel, Zhongjun Tan
On Fri, 8 Jul 2022 11:51:54 +0800 Zhongjun Tan wrote:
> From: Zhongjun Tan <tanzhongjun@coolpad.com>
>
> Remove condition with no effect
The code is fine, please fix the tool you're using to not generate such
patches.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-08 22:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-08 3:51 [PATCH] iavf: Remove condition with no effect Zhongjun Tan
2022-07-08 22:14 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).