Re: [RFC PATCH net-next v4 2/4] net/sched: flower: Add PPPoE filter

Guillaume Nault
2022-07-12T17:31:21Z

On Mon, Jul 11, 2022 at 10:26:21AM +0000, Drewek, Wojciech wrote:
> > > +static void fl_set_key_pppoe(struct nlattr **tb,
> > > + struct flow_dissector_key_pppoe *key_val,
> > > + struct flow_dissector_key_pppoe *key_mask,
> > > + struct fl_flow_key *key,
> > > + struct fl_flow_key *mask)
> > > +{
> > > + /* key_val::type must be set to ETH_P_PPP_SES
> > > + * because ETH_P_PPP_SES was stored in basic.n_proto
> > > + * which might get overwritten by ppp_proto
> > > + * or might be set to 0, the role of key_val::type
> > > + * is simmilar to vlan_key::tpid
> >
> > Didn't you mean "vlan_tpid"?
>
> Yes, is vlan_key::tpid not clear/valid?

At least it wasn't entirely clear to me as I wondered if I got the
comment right. And it's basically free to use the real name of the
structure field.