Re: [RFC PATCH net-next v4 1/4] flow_dissector: Add PPPoE dissectors

Guillaume Nault
2022-07-17T11:15:39Z

On Wed, Jul 13, 2022 at 01:54:35PM +0000, Drewek, Wojciech wrote:
> I think this should work with both LE and BE arch, what do you think Guillaume?
> We don't want to spam so much with next versions so maybe it is better
> to ask earlier.
>
> u16 ppp_proto;
>
> ppp_proto = ntohs(hdr->proto);
> if (ppp_proto & 256) {
> ppp_proto = htons(ppp_proto >> 8);
> nhoff += PPPOE_SES_HLEN - 1;
> } else {
> ppp_proto = htons(ppp_proto);
> nhoff += PPPOE_SES_HLEN;
> }

Sorry for responding late. I was away this week (and will be next week
too) and have very sporadic (and slow) Internet connection and limitted
time for review. I saw you've sent a v5 with this code, I'll reply
there. Thanks for being so patient.