* [PATCH v2] staging: qlge: Fix indentation issue under long for loop
@ 2022-07-10 8:36 Binyi Han
2022-07-10 15:28 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Binyi Han @ 2022-07-10 8:36 UTC (permalink / raw)
To: Manish Chopra, GR-Linux-NIC-Dev, Coiby Xu, Greg Kroah-Hartman,
Joe Perches
Cc: netdev, linux-staging, linux-kernel
Fix indentation issue to adhere to Linux kernel coding style,
Issue found by checkpatch. And change the long for loop into 3 lines.
Signed-off-by: Binyi Han <dantengknight@gmail.com>
---
v2:
- Change the long for loop into 3 lines.
drivers/staging/qlge/qlge_main.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 1a378330d775..6e771d0e412b 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -3007,10 +3007,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
tmp = (u64)rx_ring->lbq.base_dma;
base_indirect_ptr = rx_ring->lbq.base_indirect;
- for (page_entries = 0; page_entries <
- MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
- base_indirect_ptr[page_entries] =
- cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
+ for (page_entries = 0;
+ page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
+ page_entries++)
+ base_indirect_ptr[page_entries] =
+ cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
cqicb->lbq_addr = cpu_to_le64(rx_ring->lbq.base_indirect_dma);
cqicb->lbq_buf_size =
cpu_to_le16(QLGE_FIT16(qdev->lbq_buf_size));
@@ -3022,10 +3023,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
tmp = (u64)rx_ring->sbq.base_dma;
base_indirect_ptr = rx_ring->sbq.base_indirect;
- for (page_entries = 0; page_entries <
- MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
- base_indirect_ptr[page_entries] =
- cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
+ for (page_entries = 0;
+ page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
+ page_entries++)
+ base_indirect_ptr[page_entries] =
+ cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
cqicb->sbq_addr =
cpu_to_le64(rx_ring->sbq.base_indirect_dma);
cqicb->sbq_buf_size = cpu_to_le16(SMALL_BUFFER_SIZE);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: qlge: Fix indentation issue under long for loop
2022-07-10 8:36 [PATCH v2] staging: qlge: Fix indentation issue under long for loop Binyi Han
@ 2022-07-10 15:28 ` Joe Perches
2022-07-10 20:55 ` binyi
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2022-07-10 15:28 UTC (permalink / raw)
To: Binyi Han, Manish Chopra, GR-Linux-NIC-Dev, Coiby Xu,
Greg Kroah-Hartman
Cc: netdev, linux-staging, linux-kernel
On Sun, 2022-07-10 at 01:36 -0700, Binyi Han wrote:
> Fix indentation issue to adhere to Linux kernel coding style,
> Issue found by checkpatch. And change the long for loop into 3 lines.
>
> Signed-off-by: Binyi Han <dantengknight@gmail.com>
> ---
> v2:
> - Change the long for loop into 3 lines.
>
> drivers/staging/qlge/qlge_main.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> index 1a378330d775..6e771d0e412b 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -3007,10 +3007,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
> tmp = (u64)rx_ring->lbq.base_dma;
> base_indirect_ptr = rx_ring->lbq.base_indirect;
>
> - for (page_entries = 0; page_entries <
> - MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> - base_indirect_ptr[page_entries] =
> - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> + for (page_entries = 0;
> + page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
> + page_entries++)
> + base_indirect_ptr[page_entries] =
> + cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
Better to align page_entries to the open parenthesis.
And another optimization would be to simply add DB_PAGE_SIZE to tmp
in the loop and avoid the multiply.
for (page_entries = 0;
page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
page_entries++) {
base_indirect_ptr[page_entries] = cpu_to_le64(tmp);
tmp += DB_PAGE_SIZE;
}
> @@ -3022,10 +3023,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
> tmp = (u64)rx_ring->sbq.base_dma;
> base_indirect_ptr = rx_ring->sbq.base_indirect;
>
> - for (page_entries = 0; page_entries <
> - MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> - base_indirect_ptr[page_entries] =
> - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> + for (page_entries = 0;
> + page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
> + page_entries++)
> + base_indirect_ptr[page_entries] =
> + cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
here too
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] staging: qlge: Fix indentation issue under long for loop
2022-07-10 15:28 ` Joe Perches
@ 2022-07-10 20:55 ` binyi
0 siblings, 0 replies; 3+ messages in thread
From: binyi @ 2022-07-10 20:55 UTC (permalink / raw)
To: Joe Perches
Cc: Manish Chopra, GR-Linux-NIC-Dev, Coiby Xu, Greg Kroah-Hartman,
netdev, linux-staging, linux-kernel
On Sun, Jul 10, 2022 at 08:28:57AM -0700, Joe Perches wrote:
> On Sun, 2022-07-10 at 01:36 -0700, Binyi Han wrote:
> > Fix indentation issue to adhere to Linux kernel coding style,
> > Issue found by checkpatch. And change the long for loop into 3 lines.
> >
> > Signed-off-by: Binyi Han <dantengknight@gmail.com>
> > ---
> > v2:
> > - Change the long for loop into 3 lines.
> >
> > drivers/staging/qlge/qlge_main.c | 18 ++++++++++--------
> > 1 file changed, 10 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> > index 1a378330d775..6e771d0e412b 100644
> > --- a/drivers/staging/qlge/qlge_main.c
> > +++ b/drivers/staging/qlge/qlge_main.c
> > @@ -3007,10 +3007,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
> > tmp = (u64)rx_ring->lbq.base_dma;
> > base_indirect_ptr = rx_ring->lbq.base_indirect;
> >
> > - for (page_entries = 0; page_entries <
> > - MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> > - base_indirect_ptr[page_entries] =
> > - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> > + for (page_entries = 0;
> > + page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
> > + page_entries++)
> > + base_indirect_ptr[page_entries] =
> > + cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
>
> Better to align page_entries to the open parenthesis.
>
> And another optimization would be to simply add DB_PAGE_SIZE to tmp
> in the loop and avoid the multiply.
>
> for (page_entries = 0;
> page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
> page_entries++) {
> base_indirect_ptr[page_entries] = cpu_to_le64(tmp);
> tmp += DB_PAGE_SIZE;
> }
>
> > @@ -3022,10 +3023,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
> > tmp = (u64)rx_ring->sbq.base_dma;
> > base_indirect_ptr = rx_ring->sbq.base_indirect;
> >
> > - for (page_entries = 0; page_entries <
> > - MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> > - base_indirect_ptr[page_entries] =
> > - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> > + for (page_entries = 0;
> > + page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
> > + page_entries++)
> > + base_indirect_ptr[page_entries] =
> > + cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
>
> here too
>
Ah I see, that makes sense. Thanks for reviewing!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-10 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-10 8:36 [PATCH v2] staging: qlge: Fix indentation issue under long for loop Binyi Han
2022-07-10 15:28 ` Joe Perches
2022-07-10 20:55 ` binyi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).