From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 00699C43334
	for <netdev@archiver.kernel.org>; Tue, 12 Jul 2022 03:22:57 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231474AbiGLDWy (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 11 Jul 2022 23:22:54 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41296 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229839AbiGLDWx (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 11 Jul 2022 23:22:53 -0400
Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E3E930548;
        Mon, 11 Jul 2022 20:22:52 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id 4CEA0B81640;
        Tue, 12 Jul 2022 03:22:51 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E45AC341C8;
        Tue, 12 Jul 2022 03:22:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1657596170;
        bh=mlqo2/6ifKxCzilz7pOF7La1Lz8923WktrMarsgcVyY=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=tUILhSAOvdKDm8hA/D+bODhCDTpcCbUr51nbfAESQkqa0VmN2M64aIqDEelwCsB/X
         Gyr85v4jNmW8iIkjQoyjhiySJnSr/pfhLN/xeZpzPj3t3CB6GFIGjvTXCA/dcZiy1G
         udeHiNWeyxAByAIBqaUPCzZ31Q1cMfp0gNgzt3o5IkDGaBdWHFCNLao847t4PkgEhP
         pLCv3m3csHZZBOnDjV1WyH2IlU6UjnyZkBnCGIKuiyfHSZ+gytYn0RMKP0tfXySVWf
         yzNXeTtn4dTJBvydXHfj8cXsGvLsPPnbphLpRu2x5OsZppCtNAVmJw3XGi0R01uR72
         8eDCBF9aRfylg==
Date:   Mon, 11 Jul 2022 20:22:48 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Yevhen Orlov <yevhen.orlov@plvision.eu>
Cc:     netdev@vger.kernel.org,
        Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/9] net: marvell: prestera: Add router
 nexthops ABI
Message-ID: <20220711202248.7669f039@kernel.org>
In-Reply-To: <20220710172208.29851-2-yevhen.orlov@plvision.eu>
References: <20220710172208.29851-1-yevhen.orlov@plvision.eu>
        <20220710172208.29851-2-yevhen.orlov@plvision.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Sun, 10 Jul 2022 20:21:59 +0300 Yevhen Orlov wrote:
> @@ -591,6 +600,7 @@ void prestera_router_fini(struct prestera_switch *sw)
>  	unregister_fib_notifier(&init_net, &sw->router->fib_nb);
>  	unregister_inetaddr_notifier(&sw->router->inetaddr_nb);
>  	unregister_inetaddr_validator_notifier(&sw->router->inetaddr_valid_nb);
> +	kfree(sw->router->nhgrp_hw_state_cache);

Ah, you based it on top of the fix. We'll merge the fixes and -next on
Thursday so please wait until that happens. In the meantime you can
think of finding someone who could review the changes and speed things
up that way. You CCed a lot of Marvell and plvision people on these
but nobody from the community who actually works on routing offload...