From: Jakub Kicinski <kuba@kernel.org>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: netdev@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH] net: virtio_net: notifications coalescing support
Date: Mon, 11 Jul 2022 20:36:59 -0700 [thread overview]
Message-ID: <20220711203659.012a79b8@kernel.org> (raw)
In-Reply-To: <20220711112832.2634312-1-alvaro.karsz@solid-run.com>
On Mon, 11 Jul 2022 14:28:32 +0300 Alvaro Karsz wrote:
> New VirtIO network feature: VIRTIO_NET_F_NOTF_COAL.
>
> Control a Virtio network device notifications coalescing parameters
> using the control virtqueue.
>
> A device that supports this fetature can receive
> VIRTIO_NET_CTRL_NOTF_COAL control commands.
>
> - VIRTIO_NET_CTRL_NOTF_COAL_TX_SET:
> Ask the network device to change the following parameters:
> - tx_usecs: Maximum number of usecs to delay a TX notification.
> - tx_max_packets: Maximum number of packets to send before a
> TX notification.
>
> - VIRTIO_NET_CTRL_NOTF_COAL_RX_SET:
> Ask the network device to change the following parameters:
> - rx_usecs: Maximum number of usecs to delay a RX notification.
> - rx_max_packets: Maximum number of packets to receive before a
> RX notification.
>
> VirtIO spec. patch:
> https://lists.oasis-open.org/archives/virtio-comment/202206/msg00100.html
>
> Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
Try building with sparse -
https://www.kernel.org/doc/html/latest/dev-tools/sparse.html
+../drivers/net/virtio_net.c:2616:34: warning: incorrect type in assignment (different base types)
+../drivers/net/virtio_net.c:2616:34: expected restricted __virtio32 [usertype] tx_usecs
+../drivers/net/virtio_net.c:2616:34: got unsigned int [usertype] tx_coalesce_usecs
+../drivers/net/virtio_net.c:2617:40: warning: incorrect type in assignment (different base types)
+../drivers/net/virtio_net.c:2617:40: expected restricted __virtio32 [usertype] tx_max_packets
+../drivers/net/virtio_net.c:2617:40: got unsigned int [usertype] tx_max_coalesced_frames
+../drivers/net/virtio_net.c:2629:34: warning: incorrect type in assignment (different base types)
+../drivers/net/virtio_net.c:2629:34: expected restricted __virtio32 [usertype] rx_usecs
+../drivers/net/virtio_net.c:2629:34: got unsigned int [usertype] rx_coalesce_usecs
+../drivers/net/virtio_net.c:2630:40: warning: incorrect type in assignment (different base types)
+../drivers/net/virtio_net.c:2630:40: expected restricted __virtio32 [usertype] rx_max_packets
+../drivers/net/virtio_net.c:2630:40: got unsigned int [usertype] rx_max_coalesced_frames
next prev parent reply other threads:[~2022-07-12 3:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 11:28 [PATCH] net: virtio_net: notifications coalescing support Alvaro Karsz
2022-07-12 3:36 ` Jakub Kicinski [this message]
2022-07-12 6:29 ` Alvaro Karsz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220711203659.012a79b8@kernel.org \
--to=kuba@kernel.org \
--cc=alvaro.karsz@solid-run.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).