From: Jakub Kicinski <kuba@kernel.org>
To: Lior Nahmanson <liorna@nvidia.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Raed Salem <raeds@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Yossi Kuperman <yossiku@nvidia.com>
Subject: Re: [PATCH net-next v3 2/3] net/macsec: Add MACsec skb extension Rx Data path support
Date: Tue, 12 Jul 2022 17:01:59 -0700 [thread overview]
Message-ID: <20220712170159.6da38d1b@kernel.org> (raw)
In-Reply-To: <PH0PR12MB54490D24F44759ACDABC950FBF869@PH0PR12MB5449.namprd12.prod.outlook.com>
On Tue, 12 Jul 2022 06:50:52 +0000 Lior Nahmanson wrote:
> i considered the usage of skb_metadata_dst, however i still think
> that skb_ext will fit more to MACsec offload implementation for the following reasons:
> 1. for Rx, each skb can have a different SCI and offloaded values which mandate allocation
> of metadata_dst for each skb which contradicts the desired usage for skb_metadata_dst where
> it's allocated once and a refcnt held whenever used.
How many distinct SCIs do you expect to see?
> 2. skb_ext method is used in a similar IPsec offload implementation which in the future could make it easier
> to refactor this section to unify all crypto offloads skb_ext usage.
MACSec is L2, IPsec has constraints we have to work around.
next prev parent reply other threads:[~2022-07-13 0:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 11:19 [PATCH net-next v3 00/3] Introduce MACsec offload SKB extension Lior Nahmanson
2022-06-13 11:19 ` [PATCH net-next v3 1/3] net/macsec: Add MACsec skb extension Tx Data path support Lior Nahmanson
2022-06-13 11:19 ` [PATCH net-next v3 2/3] net/macsec: Add MACsec skb extension Rx " Lior Nahmanson
2022-06-14 13:55 ` Paolo Abeni
2022-06-14 16:14 ` Jakub Kicinski
2022-06-21 12:39 ` Lior Nahmanson
2022-06-21 19:26 ` Jakub Kicinski
2022-07-12 6:50 ` Lior Nahmanson
2022-07-13 0:01 ` Jakub Kicinski [this message]
2022-07-13 6:21 ` Lior Nahmanson
2022-07-13 18:34 ` Jakub Kicinski
2022-07-13 19:31 ` Saeed Mahameed
2022-06-13 11:19 ` [PATCH net-next v3 3/3] net/macsec: Move some code for sharing with various drivers that implements offload Lior Nahmanson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712170159.6da38d1b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@nvidia.com \
--cc=liorna@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raeds@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=yossiku@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).