From: Jakub Kicinski <kuba@kernel.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v2 2/2] selftests/net: test nexthop without gw
Date: Tue, 12 Jul 2022 17:25:15 -0700 [thread overview]
Message-ID: <20220712172515.126dc119@kernel.org> (raw)
In-Reply-To: <Ys1JefI+co1IFda4@kroah.com>
On Tue, 12 Jul 2022 12:14:17 +0200 Greg KH wrote:
> On Tue, Jul 12, 2022 at 11:55:45AM +0200, Nicolas Dichtel wrote:
> > This test implement the scenario described in the previous patch.
>
> "previous patch" does not work well when things are committed to the
> kernel tree. Please be descriptive.
And please don't resend your patches in reply to the previous version.
Add a lore link to the previous version in the commit message if you
want. In-reply-to breaks the review ordering for us :/
next prev parent reply other threads:[~2022-07-13 0:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 16:05 [PATCH net 1/2] ip: fix dflt addr selection for connected nexthop Nicolas Dichtel
2022-07-06 16:05 ` [PATCH net 2/2] selftests/net: test nexthop without gw Nicolas Dichtel
2022-07-12 8:19 ` Paolo Abeni
2022-07-12 9:19 ` Nicolas Dichtel
2022-07-12 9:55 ` [PATCH net v2 1/2] ip: fix dflt addr selection for connected nexthop Nicolas Dichtel
2022-07-12 9:55 ` [PATCH net v2 2/2] selftests/net: test nexthop without gw Nicolas Dichtel
2022-07-12 10:14 ` Greg KH
2022-07-13 0:25 ` Jakub Kicinski [this message]
2022-07-13 7:36 ` Nicolas Dichtel
2022-07-13 18:13 ` Jakub Kicinski
2022-07-13 7:35 ` Nicolas Dichtel
2022-07-12 8:11 ` [PATCH net 1/2] ip: fix dflt addr selection for connected nexthop Paolo Abeni
2022-07-12 8:45 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712172515.126dc119@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).