From: Jakub Kicinski <kuba@kernel.org>
To: Hayes Wang <hayeswang@realtek.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
davem@davemloft.net, netdev@vger.kernel.org,
nic_swsd@realtek.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] r8152: fix accessing unset transport header
Date: Tue, 12 Jul 2022 17:37:19 -0700 [thread overview]
Message-ID: <20220712173719.0e834365@kernel.org> (raw)
In-Reply-To: <e3745b77b8537e08bbace5088d9f41e21755e08b.camel@redhat.com>
On Tue, 12 Jul 2022 15:06:25 +0200 Paolo Abeni wrote:
> On Mon, 2022-07-11 at 15:00 +0800, Hayes Wang wrote:
> > A warning is triggered by commit 66e4c8d95008 ("net: warn if transport
> > header was not set"). The warning is harmless, because the value from
> > skb_transport_offset() is only used for skb_is_gso() is true or the
> > skb->ip_summed is equal to CHECKSUM_PARTIAL.
> >
> > Signed-off-by: Hayes Wang <hayeswang@realtek.com>
>
> If this is targeting the -net tree please add a suitable Fixes tag,
> thanks!
And FWIW I think the fixes tag you want is:
Fixes: 66e4c8d95008 ("net: warn if transport header was not set")
next prev parent reply other threads:[~2022-07-13 0:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 7:00 [PATCH net] r8152: fix accessing unset transport header Hayes Wang
2022-07-12 13:06 ` Paolo Abeni
2022-07-13 0:37 ` Jakub Kicinski [this message]
2022-07-13 3:31 ` [PATCH v2 " Hayes Wang
2022-07-13 14:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712173719.0e834365@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).