From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C58BC433EF for ; Wed, 13 Jul 2022 00:37:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230300AbiGMAhb (ORCPT ); Tue, 12 Jul 2022 20:37:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231905AbiGMAha (ORCPT ); Tue, 12 Jul 2022 20:37:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAD22B7D6A; Tue, 12 Jul 2022 17:37:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C8C361852; Wed, 13 Jul 2022 00:37:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 748CAC3411C; Wed, 13 Jul 2022 00:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657672648; bh=zrEAqCvFaLLRfDkoCkAVybVZ0VUg0r6WiAhoHWGPViU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=POM9zk+cYuG8o1oZk2xlHZdtmynzg8avxWcTBUX8reU8tgQ+AHP8ej2XVH5woil6q a82BdQYfUnGT1aAYmh/3UxC1vOzG8glQr5JDazfnP/PwbmlcyRJkOak1ajzwaf3XhD 0JfWp+IzEVfSyecROZ/WuSaKwwAiteku88YP/xnCzFLZNsJpXxvitCbt0YEboWrCWB CW/oHbmpaS1U7+cl25XGgoaPexqTw5A8l32a4cqq/ndrSVwh6DRDdWWrCsZ/Jij3DF PBYxrIAqh+evFBkqj4BSYczxw8I/IgyYAAp+Ys+aifYIo/5JHYul8rrJHCNcs5rMta aspntO1csOddg== Date: Tue, 12 Jul 2022 17:37:19 -0700 From: Jakub Kicinski To: Hayes Wang Cc: Paolo Abeni , davem@davemloft.net, netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] r8152: fix accessing unset transport header Message-ID: <20220712173719.0e834365@kernel.org> In-Reply-To: References: <20220711070004.28010-389-nic_swsd@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 12 Jul 2022 15:06:25 +0200 Paolo Abeni wrote: > On Mon, 2022-07-11 at 15:00 +0800, Hayes Wang wrote: > > A warning is triggered by commit 66e4c8d95008 ("net: warn if transport > > header was not set"). The warning is harmless, because the value from > > skb_transport_offset() is only used for skb_is_gso() is true or the > > skb->ip_summed is equal to CHECKSUM_PARTIAL. > > > > Signed-off-by: Hayes Wang > > If this is targeting the -net tree please add a suitable Fixes tag, > thanks! And FWIW I think the fixes tag you want is: Fixes: 66e4c8d95008 ("net: warn if transport header was not set")