From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 835E9C433EF for ; Thu, 14 Jul 2022 03:39:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233034AbiGNDjP (ORCPT ); Wed, 13 Jul 2022 23:39:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232130AbiGNDjO (ORCPT ); Wed, 13 Jul 2022 23:39:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8557F13FA1; Wed, 13 Jul 2022 20:39:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E43561E3A; Thu, 14 Jul 2022 03:39:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA429C34114; Thu, 14 Jul 2022 03:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657769952; bh=zopjln99q1rxFvM6ak58aizazSshf28UHBqgM18CFvY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O17AZt/AeHkPn061iiEgqkpCxr/6kBkYFumRDxFpzpRDC0oakyZZ3XRGmfmEY6Ei9 3ywnUmTLEXIsHlVvHMGqzUgTIpER87EFYeXOUR4n/d6QlwlK/L0Qmk8IRQ32aEqWdO +TRWuSukauk6OJIVXPhjRbYzN8zLn+pXZ1FOgs/Md9SffssjYPWH+RzvTOOR3XEm+K 7vnP1QnI8vnpRqzgkdhK1tFUJDN0trTKm+UI85RlhJTRLnmpf6th0iuPXZsZGNsfNr KrJuGiYy2WyUx3ImBk01c8POD00qj2MivZaDPDLEOrZHOJZ1icPv4DjGAl3WhPv/OR ppqEbKU1SP4kA== Date: Wed, 13 Jul 2022 20:39:10 -0700 From: Jakub Kicinski To: Biao Huang Cc: David Miller , Matthias Brugger , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Eric Dumazet , Paolo Abeni , Maxime Coquelin , AngeloGioacchino Del Regno , , , , , , , Jisheng Zhang , Mohammad Athari Bin Ismail Subject: Re: [PATCH net v4 3/3] net: stmmac: fix unbalanced ptp clock issue in suspend/resume flow Message-ID: <20220713203910.74d36732@kernel.org> In-Reply-To: <20220713101002.10970-4-biao.huang@mediatek.com> References: <20220713101002.10970-1-biao.huang@mediatek.com> <20220713101002.10970-4-biao.huang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 13 Jul 2022 18:10:02 +0800 Biao Huang wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 197fac587ad5..c230b8b9aab1 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -839,14 +839,6 @@ int stmmac_init_tstamp_counter(struct stmmac_priv *priv, u32 systime_flags) > if (!(priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp)) > return -EOPNOTSUPP; > > - ret = clk_prepare_enable(priv->plat->clk_ptp_ref); > - if (ret < 0) { > - netdev_warn(priv->dev, > - "failed to enable PTP reference clock: %pe\n", > - ERR_PTR(ret)); > - return ret; > - } > - > stmmac_config_hw_tstamping(priv, priv->ptpaddr, systime_flags); > priv->systime_flags = systime_flags; > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:837:6: warning: unused variable 'ret' [-Wunused-variable] int ret; ^