Re: [RFC PATCH net-next 3/3] net: dsa: never skip VLAN configuration

[Vladimir Oltean <vladimir.oltean@nxp.com>]

Hi Arun,

On Thu, Jul 14, 2022 at 10:46:02AM +0000, Arun.Ramadoss@microchip.com wrote:
> Hi Vladimir,
> We couldn't able to setup the selftests and failed during installation
> of packages. In the mean time, We tried the following things
> 
> Setup - Host1 --> lan1 --> lan2 --> Host2. Packet transmitted from
> Host1 and received by Host2.
> 
> Scenario-1: Vlan aware system and both lan1 & lan2 are in same vid
> ip link set dev br0 type bridge vlan_filtering 1
> bridge vlan add dev lan2 vid 10 pvid untagged
> bridge vlan add dev lan1 vid 10 pvid untagged
> 
> Packet transmitted from Host1 with vid 10 is received by the Host2.
> Packet transmitted from Host1 with vid 5 is not received by the Host2.
> 
> Scenario-2: Vlan unaware system 
> ip link set dev br0 type bridge vlan_filtering 0
> 
> Now, irrespective of the vid, the packets are received by Host2
> Packet transmitted from Host1 with vid 10 is received by the Host2.
> Packet transmitted from Host1 with vid 5 is  received by the Host2.
> 
> Whether the above approach is correct or do we need to test anything
> further.
> 
> Thanks
> Arun 

The above is correct to the extent that it is a valid configuration,
but isn't what my pvid_change() selftest was intended to capture.

The pvid_change() selftest from patch 1/3
https://patchwork.kernel.org/project/netdevbpf/patch/20220705173114.2004386-2-vladimir.oltean@nxp.com/
checks that VLAN-unaware forwarding still takes place after this array
of operations:

ip link add br0 type bridge vlan_filtering 0 # notice the 0 instead of 1
ip link set $swp1 master br0
ip link set $swp2 master br0
bridge vlan add vid 3 dev $swp1 pvid untagged # notice how VID 3 is absent on $swp2

If you let me know if this works, I can continue and resend this patch
set while you figure out the kselftest setup issues.