From: Jakub Kicinski <kuba@kernel.org>
To: Sieng-Piaw Liew <liew.s.piaw@gmail.com>
Cc: davem@davemloft.net, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atl1c: use netif_tx_napi_add() for Tx NAPI
Date: Thu, 14 Jul 2022 21:38:57 -0700 [thread overview]
Message-ID: <20220714213857.45d4bf3e@kernel.org> (raw)
In-Reply-To: <20220715042131.1237-1-liew.s.piaw@gmail.com>
On Fri, 15 Jul 2022 12:21:31 +0800 Sieng-Piaw Liew wrote:
> Use netif_tx_napi_add() for NAPI in Tx direction instead of the regular
> netif_napi_add() function.
>
> Signed-off-by: Sieng-Piaw Liew <liew.s.piaw@gmail.com>
Please use netif_napi_add_tx(), since you use the default weight
anyway there's no need to specify it.
> diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> index 948584761e66..bf293a3ed4c9 100644
> --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> @@ -2734,8 +2734,8 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> netif_napi_add(netdev, &adapter->rrd_ring[i].napi,
> atl1c_clean_rx, 64);
> for (i = 0; i < adapter->tx_queue_count; ++i)
> - netif_napi_add(netdev, &adapter->tpd_ring[i].napi,
> - atl1c_clean_tx, 64);
> + netif_napi_add_tx_weight(netdev, &adapter->tpd_ring[i].napi,
> + atl1c_clean_tx, 64);
> timer_setup(&adapter->phy_config_timer, atl1c_phy_config, 0);
> /* setup the private structure */
> err = atl1c_sw_init(adapter);
next prev parent reply other threads:[~2022-07-15 4:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 4:21 [PATCH] atl1c: use netif_tx_napi_add() for Tx NAPI Sieng-Piaw Liew
2022-07-15 4:38 ` Jakub Kicinski [this message]
2022-07-15 7:50 ` [PATCH net-next v2] atl1c: use netif_napi_add_tx() " Sieng-Piaw Liew
2022-07-18 10:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714213857.45d4bf3e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=liew.s.piaw@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).