* [PATCH] atl1c: use netif_tx_napi_add() for Tx NAPI
@ 2022-07-15 4:21 Sieng-Piaw Liew
2022-07-15 4:38 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Sieng-Piaw Liew @ 2022-07-15 4:21 UTC (permalink / raw)
To: davem, kuba, pabeni, netdev, linux-kernel; +Cc: Sieng-Piaw Liew
Use netif_tx_napi_add() for NAPI in Tx direction instead of the regular
netif_napi_add() function.
Signed-off-by: Sieng-Piaw Liew <liew.s.piaw@gmail.com>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 948584761e66..bf293a3ed4c9 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -2734,8 +2734,8 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
netif_napi_add(netdev, &adapter->rrd_ring[i].napi,
atl1c_clean_rx, 64);
for (i = 0; i < adapter->tx_queue_count; ++i)
- netif_napi_add(netdev, &adapter->tpd_ring[i].napi,
- atl1c_clean_tx, 64);
+ netif_napi_add_tx_weight(netdev, &adapter->tpd_ring[i].napi,
+ atl1c_clean_tx, 64);
timer_setup(&adapter->phy_config_timer, atl1c_phy_config, 0);
/* setup the private structure */
err = atl1c_sw_init(adapter);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] atl1c: use netif_tx_napi_add() for Tx NAPI
2022-07-15 4:21 [PATCH] atl1c: use netif_tx_napi_add() for Tx NAPI Sieng-Piaw Liew
@ 2022-07-15 4:38 ` Jakub Kicinski
2022-07-15 7:50 ` [PATCH net-next v2] atl1c: use netif_napi_add_tx() " Sieng-Piaw Liew
0 siblings, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2022-07-15 4:38 UTC (permalink / raw)
To: Sieng-Piaw Liew; +Cc: davem, pabeni, netdev, linux-kernel
On Fri, 15 Jul 2022 12:21:31 +0800 Sieng-Piaw Liew wrote:
> Use netif_tx_napi_add() for NAPI in Tx direction instead of the regular
> netif_napi_add() function.
>
> Signed-off-by: Sieng-Piaw Liew <liew.s.piaw@gmail.com>
Please use netif_napi_add_tx(), since you use the default weight
anyway there's no need to specify it.
> diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> index 948584761e66..bf293a3ed4c9 100644
> --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> @@ -2734,8 +2734,8 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> netif_napi_add(netdev, &adapter->rrd_ring[i].napi,
> atl1c_clean_rx, 64);
> for (i = 0; i < adapter->tx_queue_count; ++i)
> - netif_napi_add(netdev, &adapter->tpd_ring[i].napi,
> - atl1c_clean_tx, 64);
> + netif_napi_add_tx_weight(netdev, &adapter->tpd_ring[i].napi,
> + atl1c_clean_tx, 64);
> timer_setup(&adapter->phy_config_timer, atl1c_phy_config, 0);
> /* setup the private structure */
> err = atl1c_sw_init(adapter);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next v2] atl1c: use netif_napi_add_tx() for Tx NAPI
2022-07-15 4:38 ` Jakub Kicinski
@ 2022-07-15 7:50 ` Sieng-Piaw Liew
2022-07-18 10:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 4+ messages in thread
From: Sieng-Piaw Liew @ 2022-07-15 7:50 UTC (permalink / raw)
To: davem, kuba, netdev, linux-kernel; +Cc: Sieng-Piaw Liew
Use netif_napi_add_tx() for NAPI in Tx direction instead of the regular
netif_napi_add() function.
Signed-off-by: Sieng-Piaw Liew <liew.s.piaw@gmail.com>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 948584761e66..a6d55f452e2f 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -2734,8 +2734,8 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
netif_napi_add(netdev, &adapter->rrd_ring[i].napi,
atl1c_clean_rx, 64);
for (i = 0; i < adapter->tx_queue_count; ++i)
- netif_napi_add(netdev, &adapter->tpd_ring[i].napi,
- atl1c_clean_tx, 64);
+ netif_napi_add_tx(netdev, &adapter->tpd_ring[i].napi,
+ atl1c_clean_tx);
timer_setup(&adapter->phy_config_timer, atl1c_phy_config, 0);
/* setup the private structure */
err = atl1c_sw_init(adapter);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next v2] atl1c: use netif_napi_add_tx() for Tx NAPI
2022-07-15 7:50 ` [PATCH net-next v2] atl1c: use netif_napi_add_tx() " Sieng-Piaw Liew
@ 2022-07-18 10:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-07-18 10:40 UTC (permalink / raw)
To: Sieng-Piaw Liew; +Cc: davem, kuba, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 15 Jul 2022 15:50:43 +0800 you wrote:
> Use netif_napi_add_tx() for NAPI in Tx direction instead of the regular
> netif_napi_add() function.
>
> Signed-off-by: Sieng-Piaw Liew <liew.s.piaw@gmail.com>
> ---
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary with links:
- [net-next,v2] atl1c: use netif_napi_add_tx() for Tx NAPI
https://git.kernel.org/netdev/net-next/c/6e693a104207
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-18 10:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-15 4:21 [PATCH] atl1c: use netif_tx_napi_add() for Tx NAPI Sieng-Piaw Liew
2022-07-15 4:38 ` Jakub Kicinski
2022-07-15 7:50 ` [PATCH net-next v2] atl1c: use netif_napi_add_tx() " Sieng-Piaw Liew
2022-07-18 10:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).