From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A2BC43334 for ; Fri, 15 Jul 2022 23:44:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231327AbiGOXoV (ORCPT ); Fri, 15 Jul 2022 19:44:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbiGOXoU (ORCPT ); Fri, 15 Jul 2022 19:44:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C0BC13E06 for ; Fri, 15 Jul 2022 16:44:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AF50E6204D for ; Fri, 15 Jul 2022 23:44:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03CA7C341C0; Fri, 15 Jul 2022 23:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657928659; bh=+DMHe8SSIn9I0C6Mi1SK0ytQbR8W/BxJwOC3n8ThWxg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G87Cto2Z1dpkTXrklNVydoHtMtg0YvjJKgnHCjo3BG4C84e7ruKzsCCChyD/CTE2L 3gMIbFyJs0+yi3FDXx75EU/xkvUJylBHXs9nqiR8NZNAUmbn7AwfM06OW/uKo92tBg fozhx2BtFi/rVf6UJXsobryMQyq0ynfI1J1tOmwy4preJYx1Z3+TutKdHMrvGA+G21 EzPU4QMQVCczdfZSt7IQ4FTe2+oFNOQuFJTk58RSGLNm/gr5n8pfxhuiezZQ47mQ/L hlhXuIqs67FgSQxgQ5bE6zbOwT9u8ZsCXiFNRreJd/dryvWfYif64GMCleT+NQjMz5 gVEvFIr739pLw== Date: Fri, 15 Jul 2022 16:44:17 -0700 From: Jakub Kicinski To: Denis Kirjanov Cc: netdev@vger.kernel.org Subject: Re: [PATCH] net: altera: Handle dma_set_coherent_mask error codes Message-ID: <20220715164417.577cbae3@kernel.org> In-Reply-To: <20220714132342.13051-1-kda@linux-powerpc.org> References: <20220714132342.13051-1-kda@linux-powerpc.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 14 Jul 2022 16:23:42 +0300 Denis Kirjanov wrote: > handle the error in the case that DMA mask is not supportyed > > Fixes: bbd2190ce96d ("Altera TSE: Add main and header file for Altera Ethernet Driver") > Signed-off-by: Denis Kirjanov > --- > drivers/net/ethernet/altera/altera_tse_main.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c > index 8c5828582c21..7773d978321a 100644 > --- a/drivers/net/ethernet/altera/altera_tse_main.c > +++ b/drivers/net/ethernet/altera/altera_tse_main.c > @@ -1439,10 +1439,14 @@ static int altera_tse_probe(struct platform_device *pdev) > } > > if (!dma_set_mask(priv->device, DMA_BIT_MASK(priv->dmaops->dmamask))) { > - dma_set_coherent_mask(priv->device, > + ret = dma_set_coherent_mask(priv->device, > DMA_BIT_MASK(priv->dmaops->dmamask)); > + if (ret) > + goto err_free_netdev; > } else if (!dma_set_mask(priv->device, DMA_BIT_MASK(32))) { > - dma_set_coherent_mask(priv->device, DMA_BIT_MASK(32)); > + ret = dma_set_coherent_mask(priv->device, DMA_BIT_MASK(32)); > + if (ret) > + goto err_free_netdev; > } else { > ret = -EIO; > goto err_free_netdev; Practically speaking this can't fail, see Christophe's patches like b6f2f0352c0302 If you want to be on the safe side just replace the dma_set_mask() with dma_set_mask_and_coherent() and let the else branch handle the failure. Please CC maintainers when reposting.