From: Guillaume Nault <gnault@redhat.com>
To: "Drewek, Wojciech" <wojciech.drewek@intel.com>
Cc: Marcin Szycik <marcin.szycik@linux.intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"gustavoars@kernel.org" <gustavoars@kernel.org>,
"baowen.zheng@corigine.com" <baowen.zheng@corigine.com>,
"boris.sukholitko@broadcom.com" <boris.sukholitko@broadcom.com>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"kurt@linutronix.de" <kurt@linutronix.de>,
"pablo@netfilter.org" <pablo@netfilter.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"paulb@nvidia.com" <paulb@nvidia.com>,
"simon.horman@corigine.com" <simon.horman@corigine.com>,
"komachi.yoshiki@gmail.com" <komachi.yoshiki@gmail.com>,
"zhangkaiheb@126.com" <zhangkaiheb@126.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"michal.swiatkowski@linux.intel.com"
<michal.swiatkowski@linux.intel.com>,
"Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
"mostrows@earthlink.net" <mostrows@earthlink.net>,
"paulus@samba.org" <paulus@samba.org>
Subject: Re: [RFC PATCH net-next v4 1/4] flow_dissector: Add PPPoE dissectors
Date: Sun, 17 Jul 2022 13:15:23 +0200 [thread overview]
Message-ID: <20220717111523.GA3118@localhost.localdomain> (raw)
In-Reply-To: <MW4PR11MB57763D9CD8EA3F31DB7E3E19FD899@MW4PR11MB5776.namprd11.prod.outlook.com>
On Wed, Jul 13, 2022 at 01:54:35PM +0000, Drewek, Wojciech wrote:
> I think this should work with both LE and BE arch, what do you think Guillaume?
> We don't want to spam so much with next versions so maybe it is better
> to ask earlier.
>
> u16 ppp_proto;
>
> ppp_proto = ntohs(hdr->proto);
> if (ppp_proto & 256) {
> ppp_proto = htons(ppp_proto >> 8);
> nhoff += PPPOE_SES_HLEN - 1;
> } else {
> ppp_proto = htons(ppp_proto);
> nhoff += PPPOE_SES_HLEN;
> }
Sorry for responding late. I was away this week (and will be next week
too) and have very sporadic (and slow) Internet connection and limitted
time for review. I saw you've sent a v5 with this code, I'll reply
there. Thanks for being so patient.
next prev parent reply other threads:[~2022-07-17 11:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 12:24 [RFC PATCH net-next v4 0/4] ice: PPPoE offload support Marcin Szycik
2022-07-08 12:24 ` [RFC PATCH net-next v4 1/4] flow_dissector: Add PPPoE dissectors Marcin Szycik
2022-07-08 19:05 ` Guillaume Nault
2022-07-11 10:23 ` Drewek, Wojciech
2022-07-12 17:20 ` Guillaume Nault
2022-07-13 7:58 ` Drewek, Wojciech
2022-07-13 13:54 ` Drewek, Wojciech
2022-07-17 11:15 ` Guillaume Nault [this message]
2022-07-08 12:24 ` [RFC PATCH net-next v4 2/4] net/sched: flower: Add PPPoE filter Marcin Szycik
2022-07-08 19:22 ` Guillaume Nault
2022-07-11 10:26 ` Drewek, Wojciech
2022-07-12 17:31 ` Guillaume Nault
2022-07-08 12:24 ` [RFC PATCH net-next v4 3/4] flow_offload: Introduce flow_match_pppoe Marcin Szycik
2022-07-08 12:24 ` [RFC PATCH net-next v4 4/4] ice: Add support for PPPoE hardware offload Marcin Szycik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220717111523.GA3118@localhost.localdomain \
--to=gnault@redhat.com \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=baowen.zheng@corigine.com \
--cc=boris.sukholitko@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=komachi.yoshiki@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=mostrows@earthlink.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=paulb@nvidia.com \
--cc=paulus@samba.org \
--cc=simon.horman@corigine.com \
--cc=wojciech.drewek@intel.com \
--cc=xiyou.wangcong@gmail.com \
--cc=zhangkaiheb@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox