From: Max Staudt <max@enpas.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Paolo Abeni <pabeni@redhat.com>,
Wolfgang Grandegger <wg@grandegger.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH] can: can327: remove useless header inclusions
Date: Sun, 17 Jul 2022 23:50:00 +0200 [thread overview]
Message-ID: <20220717235000.247bfa42.max@enpas.org> (raw)
In-Reply-To: <20220716170201.2020510-1-dario.binacchi@amarulasolutions.com>
On Sat, 16 Jul 2022 19:02:01 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
> -#include <linux/init.h>
> #include <linux/module.h>
> -
> -#include <linux/bitops.h>
> -#include <linux/ctype.h>
> -#include <linux/errno.h>
> -#include <linux/kernel.h>
> -#include <linux/list.h>
> -#include <linux/lockdep.h>
> -#include <linux/netdevice.h>
> -#include <linux/skbuff.h>
> -#include <linux/spinlock.h>
> -#include <linux/string.h>
> #include <linux/tty.h>
> -#include <linux/tty_ldisc.h>
> -#include <linux/workqueue.h>
> -
> -#include <uapi/linux/tty.h>
> -
> -#include <linux/can.h>
> #include <linux/can/dev.h>
> -#include <linux/can/error.h>
> #include <linux/can/rx-offload.h>
AFAIK, the coding style is to not rely on headers including other
headers. Instead, the appropriate header for every symbol used should
be included.
This is also valid for the similar patch you submitted for slcan.
Unless something has changed, this is a NAK from me, sorry.
Max
next prev parent reply other threads:[~2022-07-17 21:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 17:02 [RFC PATCH] can: can327: remove useless header inclusions Dario Binacchi
2022-07-17 21:50 ` Max Staudt [this message]
2022-07-18 7:18 ` Dario Binacchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220717235000.247bfa42.max@enpas.org \
--to=max@enpas.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).