From: Stephen Hemminger <stephen@networkplumber.org>
To: Parav Pandit <parav@nvidia.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH iproute2] uapi: add vdpa.h
Date: Mon, 18 Jul 2022 09:55:15 -0700 [thread overview]
Message-ID: <20220718095515.0bdb8586@hermes.local> (raw)
In-Reply-To: <PH0PR12MB5481AAD7096EA95956ED6801DC8C9@PH0PR12MB5481.namprd12.prod.outlook.com>
On Mon, 18 Jul 2022 16:40:30 +0000
Parav Pandit <parav@nvidia.com> wrote:
> We kept this in vdpa/include/uapi/linux/vdpa.h after inputs from David.
> This is because vdpa was following rdma style sync with the kernel headers.
> Rdma subsystem kernel header is in rdma/include/uapi/rdma/rdma_netlink.h.
>
> Any reason to take different route for vdpa?
> If so, duplicate file from vdpa/include/uapi/linux/vdpa.h should be removed.
> So that there is only one vdpa.h file.
>
> If so, should we move rdma files also similarly?
>
> Similar discussion came up in the past. (don't have ready reference to the discussion).
> And David's input was to keep the way it is like rdma.
RDMA is different and contained to one directory.
VDPA is picking up things from linux/.
And the current version is not kept up to date with kernel headers.
Fixing that now.
next prev parent reply other threads:[~2022-07-18 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 16:31 [PATCH iproute2] uapi: add vdpa.h Stephen Hemminger
2022-07-18 16:40 ` patchwork-bot+netdevbpf
2022-07-18 16:42 ` Parav Pandit
2022-07-18 16:40 ` Parav Pandit
2022-07-18 16:50 ` Stephen Hemminger
2022-07-18 16:55 ` Stephen Hemminger [this message]
2022-07-18 17:51 ` David Ahern
2022-07-18 20:18 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718095515.0bdb8586@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).