Re: [net-next RFC PATCH 0/4] net: dsa: qca8k: code split for qca8k

Christian Marangi
2022-07-18T18:20:10Z

On Mon, Jul 18, 2022 at 09:15:59PM +0300, Vladimir Oltean wrote:
> On Mon, Jul 18, 2022 at 07:23:35PM +0200, Christian Marangi wrote:
> > Ok, so I have to keep the qca8k special function. Is it a problem if I
> > keep the function and than later make the conversion when we have the
> > regmap dependency merged?
>
> You mean to ask whether there's any problem if the common qca8k_fdb_read()
> calls the specific qca8k_bulk_read as opposed to regmap_bulk_read()?
>
> Well, no, considering that you don't yet support the switch with the
> MMIO regmap, the common code is still "common" for the single switch
> that the driver supports. You should be able to continue making progress
> with qca8k_bulk_read() being called from common code (as long as you
> leave a TODO comment or something, that it doesn't really belong there).

Ok I will leave a TODO comment and switch to the new implemenation when
the regmap implementation will be available. Thanks for the
clarification on how to proceed.

--
Ansuel