Re: [net-next RFC PATCH 1/4] net: dsa: qca8k: drop qca8k_read/write/rmw for regmap variant

Christian Marangi
2022-07-18T22:11:56Z

On Mon, Jul 18, 2022 at 11:30:42PM +0300, Vladimir Oltean wrote:
> On Mon, Jul 18, 2022 at 09:30:58PM +0200, Christian Marangi wrote:
> > Tell me if I got this wrong.
> >
> > The suggestion was to move the struct dsa_switch_ops to qca8k.h and add
> > in the specific code probe the needed ops to add to the generic
> > struct...
>
> The declaration yes; the definition to qca8k-common.c. See for example
> where felix_switch_ops is, relative to felix_vsc9959.c, seville_vsc9953.c
> (users), felix.h (declaration), and felix.c (definition). Or how
> mv88e6xxx_switch_ops does things and still supports a gazillion of switches.

Mhh I checked the example and they doesn't seems to be useful from my
problem. But I think it's better to discuss this to the patch directly
so you can better understand whay I intended with having dsa_switch_ops
set to const.

--
Ansuel