From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8765AC43334 for ; Wed, 20 Jul 2022 00:43:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238368AbiGTAng (ORCPT ); Tue, 19 Jul 2022 20:43:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238348AbiGTAne (ORCPT ); Tue, 19 Jul 2022 20:43:34 -0400 Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 643E45E336 for ; Tue, 19 Jul 2022 17:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1658277814; x=1689813814; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kqwROW6Syo6Pv1EncG39U7b/F39b5Rj9CiTFa8XSdu8=; b=C9CZke/cw5dikRy5FtDU/nA3R8l1O4aN+7jFGTPO+aV74KlvH64nBfJ1 yUXfi/sAl+W6l02BDORRNM5vwbpikhY8m+5+3CiPpviuHQ25zybPfGuWe tLflQo5GQ8CKqsKzb6gvkL4h7TcRkGaLeM6pzG39dmUKnJlpjs9DOqzc9 g=; X-IronPort-AV: E=Sophos;i="5.92,285,1650931200"; d="scan'208";a="211379726" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-pdx-2a-6fd66c4a.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-33001.sea14.amazon.com with ESMTP; 20 Jul 2022 00:43:18 +0000 Received: from EX13MTAUWB001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2a-6fd66c4a.us-west-2.amazon.com (Postfix) with ESMTPS id CD95596D2E; Wed, 20 Jul 2022 00:43:16 +0000 (UTC) Received: from EX19D004ANA001.ant.amazon.com (10.37.240.138) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1497.36; Wed, 20 Jul 2022 00:43:16 +0000 Received: from 88665a182662.ant.amazon.com.com (10.43.162.71) by EX19D004ANA001.ant.amazon.com (10.37.240.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1118.9; Wed, 20 Jul 2022 00:43:14 +0000 From: Kuniyuki Iwashima To: CC: , , , , , , Subject: Re: [PATCH v1 net-next] selftests: net: af_unix: Fix a build error of unix_connect.c. Date: Tue, 19 Jul 2022 17:43:05 -0700 Message-ID: <20220720004305.15822-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220719173201.01807d65@kernel.org> References: <20220719173201.01807d65@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.43.162.71] X-ClientProxiedBy: EX13D32UWA001.ant.amazon.com (10.43.160.4) To EX19D004ANA001.ant.amazon.com (10.37.240.138) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jakub Kicinski Date: Tue, 19 Jul 2022 17:32:01 -0700 > On Mon, 18 Jul 2022 09:23:50 -0700 Kuniyuki Iwashima wrote: > > This patch fixes a build error reported in the link. [0] > > > > unix_connect.c: In function ‘unix_connect_test’: > > unix_connect.c:115:55: error: expected identifier before ‘(’ token > > #define offsetof(type, member) ((size_t)&((type *)0)->(member)) > > ^ > > unix_connect.c:128:12: note: in expansion of macro ‘offsetof’ > > addrlen = offsetof(struct sockaddr_un, sun_path) + variant->len; > > ^~~~~~~~ > > Can we delete this define and use stddef.h instead? man offsetof > This is not kernel code the C standard lib is at our disposal. Ah, it works. I'll respin v2. Thank you!