netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties
@ 2022-07-20  6:39 Alexander Stein
  2022-07-25 22:18 ` Rob Herring
  2022-07-26  1:10 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2022-07-20  6:39 UTC (permalink / raw)
  To: Joakim Zhang, David S . Miller, Jakub Kicinski, Rob Herring
  Cc: Alexander Stein, netdev, devicetree

These properties are inherited from ethernet-controller.yaml.
This fixes the dt_binding_check warning:
imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Changes in v3:
* Use nvmem-cells/nvmem-cell-names properties from ethernet-controller.yaml
* Set unevaluatedProperties instead of additionalProperties

Changes in v2:
* Add amount and names of nvmem-cells (copied from ethernet-controller.yaml)

 Documentation/devicetree/bindings/net/fsl,fec.yaml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
index daa2f79a294f..85a8d8fb6b8f 100644
--- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
@@ -121,6 +121,10 @@ properties:
 
   mac-address: true
 
+  nvmem-cells: true
+
+  nvmem-cell-names: true
+
   tx-internal-delay-ps:
     enum: [0, 2000]
 
@@ -213,7 +217,7 @@ required:
 # least undocumented properties. However, PHY may have a deprecated option to
 # place PHY OF properties in the MAC node, such as Micrel PHY, and we can find
 # these boards which is based on i.MX6QDL.
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v3 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties
  2022-07-20  6:39 [PATCH v3 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties Alexander Stein
@ 2022-07-25 22:18 ` Rob Herring
  2022-07-26  1:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-07-25 22:18 UTC (permalink / raw)
  To: Alexander Stein
  Cc: netdev, devicetree, David S . Miller, Jakub Kicinski, Rob Herring,
	Joakim Zhang

On Wed, 20 Jul 2022 08:39:24 +0200, Alexander Stein wrote:
> These properties are inherited from ethernet-controller.yaml.
> This fixes the dt_binding_check warning:
> imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
> 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v3:
> * Use nvmem-cells/nvmem-cell-names properties from ethernet-controller.yaml
> * Set unevaluatedProperties instead of additionalProperties
> 
> Changes in v2:
> * Add amount and names of nvmem-cells (copied from ethernet-controller.yaml)
> 
>  Documentation/devicetree/bindings/net/fsl,fec.yaml | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties
  2022-07-20  6:39 [PATCH v3 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties Alexander Stein
  2022-07-25 22:18 ` Rob Herring
@ 2022-07-26  1:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-07-26  1:10 UTC (permalink / raw)
  To: Alexander Stein; +Cc: qiangqing.zhang, davem, kuba, robh+dt, netdev, devicetree

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 20 Jul 2022 08:39:24 +0200 you wrote:
> These properties are inherited from ethernet-controller.yaml.
> This fixes the dt_binding_check warning:
> imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
> 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> [...]

Here is the summary with links:
  - [v3,1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties
    https://git.kernel.org/netdev/net-next/c/5030a9a03f01

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-26  1:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-20  6:39 [PATCH v3 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties Alexander Stein
2022-07-25 22:18 ` Rob Herring
2022-07-26  1:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).