From: Jakub Kicinski <kuba@kernel.org>
To: Matthias May <matthias.may@westermo.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<yoshfuji@linux-ipv6.org>, <dsahern@kernel.org>,
<edumazet@google.com>, <pabeni@redhat.com>,
<nicolas.dichtel@6wind.com>, Eyal Birger <eyal.birger@gmail.com>
Subject: Re: [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames
Date: Wed, 20 Jul 2022 09:50:02 -0700 [thread overview]
Message-ID: <20220720095002.094986df@kernel.org> (raw)
In-Reply-To: <ba54b498-5388-44c2-9554-953a3cf1b8eb@westermo.com>
On Wed, 20 Jul 2022 17:24:17 +0200 Matthias May wrote:
> I finally got around to do the previously mentioned selftest for gretap, vxlan and geneve.
> See the bash-script below.
>
> Many of the vxlan/geneve tests are currently failing, with gretap working on net-next
> because of the fixes i sent.
> What is the policy on sending selftests that are failing?
> Are fixes for the failures required in advance?
>
> I'm not sure i can fix them.
> Geneve seems to ignore the 3 upper bits of the DSCP completely.
>
> My other concern is:
> The whole test is... slow.
> I tried to figure out what takes so long, and the culprit seem to be tcpdump.
> It just takes ages to start capturing, more so when it is capturing IPv6.
> Does anyone know of a better way to capture traffic and analyze it afterwards?
> I used tcpdump because other tests seem to use it, and i guess this is a tool
> that most everyone has installed (that works with networks).
Yeah, tcpdump is not great, there's a bunch of flags that make it a
little less bad (--immediate-mode?)
Looking at the last test I wrote I ended up with:
tcpdump --immediate-mode -p -ni dummy0 -w $TMPF -c 4
sleep 0.05 # wait for tcpdump to start
next prev parent reply other threads:[~2022-07-20 16:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 14:54 [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames Matthias May
2022-07-06 1:25 ` Jakub Kicinski
2022-07-06 7:07 ` Matthias May
2022-07-06 20:17 ` Jakub Kicinski
2022-07-07 11:57 ` Matthias May
2022-07-07 23:53 ` Jakub Kicinski
2022-07-07 13:59 ` Matthias May
2022-07-08 0:01 ` Jakub Kicinski
2022-07-09 20:09 ` Matthias May
2022-07-11 18:29 ` Jakub Kicinski
2022-07-11 22:06 ` Matthias May
2022-07-12 7:17 ` Nicolas Dichtel
2022-07-12 7:51 ` Matthias May
2022-07-12 8:09 ` Nicolas Dichtel
2022-07-20 15:24 ` Matthias May
2022-07-20 16:50 ` Jakub Kicinski [this message]
2022-07-21 8:25 ` Matthias May
2022-07-21 8:05 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720095002.094986df@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=matthias.may@westermo.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).