From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A680C433EF for ; Wed, 20 Jul 2022 16:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235144AbiGTQuK (ORCPT ); Wed, 20 Jul 2022 12:50:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235026AbiGTQuI (ORCPT ); Wed, 20 Jul 2022 12:50:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25B94B47 for ; Wed, 20 Jul 2022 09:50:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4295061DD7 for ; Wed, 20 Jul 2022 16:50:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59D59C3411E; Wed, 20 Jul 2022 16:50:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658335803; bh=7KCknlPec0+JAbGS2IGZ8hiGg//cpTF7TYHy42IromU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OZ3C45dqRx571Hhf2JapLCqsWWJqEXOOxNz6qAyPJwMnVPx9hFVEjxGPB6kSZdIFS ioJhA1mw+j7hH5kaA3HNHZpWmXcuDKZkjWl6oyyQJ0f77jJygr9qmwl2KD1u5860Nv gyaLKn7rfoQGSCGjIpxsiFwBJdGjQ+LlapuzdpOi9YLNCylIsXoynesf1yUw9Zn1h+ FBegFIPZdiCAFC4lC/DV8oI8X1Ta/KabYYP/3+N36BMAfPDEqn3YTc+Oyg6ySPq6h5 rsjZ+lePOulRYGy6vv5cGPIXjaZGYJA5LN3vzUIuukSMvoAIBBnX4D0ZlVestZgIMd xe+ONAm8dLjoA== Date: Wed, 20 Jul 2022 09:50:02 -0700 From: Jakub Kicinski To: Matthias May Cc: , , , , , , , Eyal Birger Subject: Re: [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames Message-ID: <20220720095002.094986df@kernel.org> In-Reply-To: References: <20220705145441.11992-1-matthias.may@westermo.com> <20220705182512.309f205e@kernel.org> <20220706131735.4d9f4562@kernel.org> <20220707170145.0666cd4c@kernel.org> <20220711112911.6e387608@kernel.org> <331695e3-bfa3-9ea7-3ba9-aebd0689251c@westermo.com> <42015af3-daa5-7435-725e-8197adbbf3b8@6wind.com> <88cbeaff-4300-b2c4-3d00-79918ec88042@westermo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 20 Jul 2022 17:24:17 +0200 Matthias May wrote: > I finally got around to do the previously mentioned selftest for gretap, vxlan and geneve. > See the bash-script below. > > Many of the vxlan/geneve tests are currently failing, with gretap working on net-next > because of the fixes i sent. > What is the policy on sending selftests that are failing? > Are fixes for the failures required in advance? > > I'm not sure i can fix them. > Geneve seems to ignore the 3 upper bits of the DSCP completely. > > My other concern is: > The whole test is... slow. > I tried to figure out what takes so long, and the culprit seem to be tcpdump. > It just takes ages to start capturing, more so when it is capturing IPv6. > Does anyone know of a better way to capture traffic and analyze it afterwards? > I used tcpdump because other tests seem to use it, and i guess this is a tool > that most everyone has installed (that works with networks). Yeah, tcpdump is not great, there's a bunch of flags that make it a little less bad (--immediate-mode?) Looking at the last test I wrote I ended up with: tcpdump --immediate-mode -p -ni dummy0 -w $TMPF -c 4 sleep 0.05 # wait for tcpdump to start