From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC218CCA483 for ; Wed, 20 Jul 2022 23:42:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231339AbiGTXmN (ORCPT ); Wed, 20 Jul 2022 19:42:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbiGTXmM (ORCPT ); Wed, 20 Jul 2022 19:42:12 -0400 Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56C7B49B42 for ; Wed, 20 Jul 2022 16:42:11 -0700 (PDT) Received: by mail-qk1-x72a.google.com with SMTP id o1so177391qkg.9 for ; Wed, 20 Jul 2022 16:42:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=W0m+zaV/t9IfMCsWddU/BD/INu7/IDz+95VLsqfyLlk=; b=U3yy46ize2deAZrpfJnMv8YMz8IGVBTnhJcNPjIo6TTb4pcJ+2Rf0HGhY3BbVcCoWV Fr6INq63FCKPdfGdT5sCcLQZ66CU1vzCoHoPBI0mRx57jWPTUrS0g23L/KjiSFAwgK+H GO1ZJiWGPLaOR8bFzBjThFgxzhauTq5H8Ad5+6uwjMjSl/nfzhtcdI3wIRqNptpEJG+U jwSMlDrGPttQJtFu4an9vV+ShopsjhzcaZ5xQTRm0xyxBBGA30nLu3urNMzTKaoyWP2f UTSIu+6q3QG1VRi/P/fHe3ypCskf/KZ6FoqFqMNWVUl/YO7cyrklzl1QWXowrdWg5hgg DvIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=W0m+zaV/t9IfMCsWddU/BD/INu7/IDz+95VLsqfyLlk=; b=uKedKKO47kJeSE+9a3GGoGhQ1NLLkcR9EwRgdH+wJqwIQD9IbdcCQKYesT0NzEKYen aRs6JRrMy1vGxeMOiIXMXik4Zx+6SEHtKcWrUzMwItLWgFb5dkrVPMa9znMCmKOaLEb3 5AFlQ50SmnnaI+est1E5ziQ8p5RxfnUc+q1OTaVBF6so9ZTZxbedwcpFx00jlr7frqOA Xo/Dvoh5tBTvncUkNgOzR/a5tgliLfOhtnsiZ4gIHMDEBnZ+wsplxaiN4+Ryp1IKjGw0 cDpy8nP/Z9CRBHeUUxC1GCqpmdUlZz+WLQTHqV5mHWRxTvbgyQsfR3PsPVBuH8Hp4ZAm spOg== X-Gm-Message-State: AJIora8TUfdWJ3RrhDnUQfV9IM27YCdT5YoABKp9Kcm/V8TUtAXJIMfq KkBPo11cLghD92Mz3ZjBPEhcqA== X-Google-Smtp-Source: AGRyM1sNUsHEctZwjSnaPLK4IglthMasJNe6r6fUvGUFoDocPR+S9bJKHQmOgtSIqhnD9Bw+dxK6qg== X-Received: by 2002:a37:555:0:b0:6b5:dace:f589 with SMTP id 82-20020a370555000000b006b5dacef589mr15076898qkf.444.1658360530482; Wed, 20 Jul 2022 16:42:10 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id z8-20020ac84308000000b0031ee1f0c420sm379908qtm.10.2022.07.20.16.42.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 16:42:09 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1oEJKT-001hih-C9; Wed, 20 Jul 2022 20:42:09 -0300 Date: Wed, 20 Jul 2022 20:42:09 -0300 From: Jason Gunthorpe To: Long Li Cc: Dexuan Cui , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Leon Romanovsky , "edumazet@google.com" , "shiraz.saleem@intel.com" , Ajay Sharma , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" Subject: Re: [Patch v4 03/12] net: mana: Handle vport sharing between devices Message-ID: <20220720234209.GP5049@ziepe.ca> References: <1655345240-26411-1-git-send-email-longli@linuxonhyperv.com> <1655345240-26411-4-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 12, 2022 at 06:48:09PM +0000, Long Li wrote: > > > @@ -563,9 +581,19 @@ static int mana_cfg_vport(struct > > > mana_port_context *apc, u32 protection_dom_id, > > > > > > apc->tx_shortform_allowed = resp.short_form_allowed; > > > apc->tx_vp_offset = resp.tx_vport_offset; > > > + > > > + netdev_info(apc->ndev, "Configured vPort %llu PD %u DB %u\n", > > > + apc->port_handle, protection_dom_id, doorbell_pg_id); > > Should this be netdev_dbg()? > > The log buffer can be flooded if there are many vPorts per VF PCI device and > > there are a lot of VFs. > > The reason netdev_info () is used is that this message is important > for troubleshooting initial setup issues with Ethernet driver. We > rely on user to get this configured right to share the same hardware > port between Ethernet and RDMA driver. As far as I know, there is no > easy way for a driver to "take over" an exclusive hardware resource > from another driver. This seems like a really strange statement. Exactly how does all of this work? Jason