From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA52DC43334 for ; Wed, 20 Jul 2022 23:43:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231589AbiGTXnl (ORCPT ); Wed, 20 Jul 2022 19:43:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231480AbiGTXnj (ORCPT ); Wed, 20 Jul 2022 19:43:39 -0400 Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC4A34D837 for ; Wed, 20 Jul 2022 16:43:38 -0700 (PDT) Received: by mail-qv1-xf31.google.com with SMTP id f9so1845510qvr.2 for ; Wed, 20 Jul 2022 16:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5RMWa0xSoaL7B2aaDLU4AquBAwXY5T4zVNdrwgZSQKQ=; b=Ot5athrApcpdcvUNzLe9OfexoqvO26PdLjB8LFKfQpvSTzGIzRKJM2L4RH1uc+ME0M 92kFtslZKestwARBw+eBvp1K34x9uqwSiUROG6sU1q1HrxlTRwpPPsuGsd0iU765aEvG Rn34ICnJN/3L/k6GhkTtDQcpLolrJlTbUm9eZdboYQHiyXyGyplYgOi4dIQJunsb5jHA nqOwyG//HVJCxRZ0UxvzSRaP8Uty4I65JmvxrKYAIDOH9TX7L1WOSA3r1mklTG+o7pNr 8fjH0DH3t3EBQukMMX2JNR5N0Q/Nw/3Y7teIU4a/lor6SePtXtaFAdvc8xcPMpZO+nax vlhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5RMWa0xSoaL7B2aaDLU4AquBAwXY5T4zVNdrwgZSQKQ=; b=tBbnvQzhbz7l/+PijCAbpReqckA8Dsj5JhP7tCJfu78ewG61+e4qVjYZR+NCsgS8Ca JWZdbVSskNRfGOFZThcmkb0Ps3hzmFc/+17VfuF9if3XxoBtE5kldB5vmmuEgQyPILG6 mgcAGO9mGOzfoQl+9kDTZZ1vcDN2DcSVaaLNBN5nK84HtemDzYLbulPj90qS+6b+pZ/+ Y5BdpwE57JHPm4JNoH4e6acW7UPE5X9hIog/+A4LEMyYRE1T0gehCLbB+QkAv7BEkX8e MB3Q2uTFPkNRQUjrsfpYY9X9uRMtyv0VrJlQ1AHBp9YWncZ2T017Amo0SY1X2w+YEcZ1 /ZUw== X-Gm-Message-State: AJIora/JpW51mZpihh/17SnTcRbhFxMUyQwHJb8aH+wcLBJhX2c4LtNp 29R1rIH9FgDkQ8WQV7Fxbwq9hg== X-Google-Smtp-Source: AGRyM1tB9R3rUDukTdF+KkNXaMIev5xhPYoFuvblwiYMzmV8PCMT2wlMNqlR3rzngTwV4TVtix/8hg== X-Received: by 2002:a05:6214:27ef:b0:474:9aa:9e4d with SMTP id jt15-20020a05621427ef00b0047409aa9e4dmr2893624qvb.82.1658360618033; Wed, 20 Jul 2022 16:43:38 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id bk4-20020a05620a1a0400b006b5fe4c333fsm364916qkb.85.2022.07.20.16.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 16:43:37 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1oEJLs-001hkt-NS; Wed, 20 Jul 2022 20:43:36 -0300 Date: Wed, 20 Jul 2022 20:43:36 -0300 From: Jason Gunthorpe To: Dexuan Cui Cc: Long Li , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Leon Romanovsky , "edumazet@google.com" , "shiraz.saleem@intel.com" , Ajay Sharma , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" Subject: Re: [Patch v4 06/12] net: mana: Define data structures for protection domain and memory registration Message-ID: <20220720234336.GR5049@ziepe.ca> References: <1655345240-26411-1-git-send-email-longli@linuxonhyperv.com> <1655345240-26411-7-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 11, 2022 at 01:29:08AM +0000, Dexuan Cui wrote: > > From: longli@linuxonhyperv.com > > Sent: Wednesday, June 15, 2022 7:07 PM > > > > The MANA hardware support protection domain and memory registration for > s/support/supports > > > diff --git a/drivers/net/ethernet/microsoft/mana/gdma.h > > b/drivers/net/ethernet/microsoft/mana/gdma.h > > index f945755760dc..b1bec8ab5695 100644 > > --- a/drivers/net/ethernet/microsoft/mana/gdma.h > > +++ b/drivers/net/ethernet/microsoft/mana/gdma.h > > @@ -27,6 +27,10 @@ enum gdma_request_type { > > GDMA_CREATE_DMA_REGION = 25, > > GDMA_DMA_REGION_ADD_PAGES = 26, > > GDMA_DESTROY_DMA_REGION = 27, > > + GDMA_CREATE_PD = 29, > > + GDMA_DESTROY_PD = 30, > > + GDMA_CREATE_MR = 31, > > + GDMA_DESTROY_MR = 32, > These are not used in this patch. They're used in the 12th > patch for the first time. Can we move these to that patch? This looks like RDMA code anyhow, why is it under net/ethernet? Jason