From: Guillaume Nault <gnault@redhat.com>
To: Matthias May <matthias.may@westermo.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
yoshfuji@linux-ipv6.org, dsahern@kernel.org, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, nicolas.dichtel@6wind.com,
eyal.birger@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2 net-next] geneve: fix TOS inheriting
Date: Mon, 25 Jul 2022 18:57:45 +0200 [thread overview]
Message-ID: <20220725165745.GC18808@pc-4.home> (raw)
In-Reply-To: <20220724003741.57816-1-matthias.may@westermo.com>
On Sun, Jul 24, 2022 at 02:37:39AM +0200, Matthias May wrote:
> Is there any reason why the flowlabel should be restricted to these
> 3 bits?
It's a bug, likely a copy/paste mistake.
> The patch simply removes the usage of this macro, but i don't
> know if there was a specific intention behind that.
RT_TOS() is an old macro used to interprete IPv4 TOS as described in
the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
code, although, given the current state of the code, most of the
existing calls have no consequence.
But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS"
field to be interpreted the RFC 1349 way. There's no historical
compatibility to worry about.
prev parent reply other threads:[~2022-07-25 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-24 0:37 [PATCH 0/2 net-next] geneve: fix TOS inheriting Matthias May
2022-07-24 0:37 ` [PATCH 1/2 net-next] geneve: fix TOS inheriting for ipv4 Matthias May
2022-07-24 0:37 ` [PATCH 2/2 net-next] geneve: fix TOS inheriting for ipv6 Matthias May
2022-07-25 17:05 ` Guillaume Nault
2022-07-26 16:29 ` Matthias May
2022-07-27 14:45 ` Guillaume Nault
2022-07-25 16:57 ` Guillaume Nault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725165745.GC18808@pc-4.home \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.may@westermo.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).