From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jonathan Toppins <jtoppins@redhat.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Hangbin Liu <liuhangbin@gmail.com>,
Brian Hutchinson <b.hutchman@gmail.com>
Subject: Re: [PATCH net] net: dsa: fix bonding with ARP monitoring by updating trans_start manually
Date: Mon, 25 Jul 2022 21:53:19 +0000 [thread overview]
Message-ID: <20220725215318.rc7ip2npzl4g6chq@skbuf> (raw)
In-Reply-To: <24e1144d-2dcc-6b33-eec0-f668d51c7a80@redhat.com>
On Mon, Jul 25, 2022 at 05:39:33PM -0400, Jonathan Toppins wrote:
> > + /* Stacked network interfaces usually have NETIF_F_LLTX so
> > + * netdev_start_xmit() -> txq_trans_update() fails to do anything,
> > + * because they don't lock the TX queue. However, layers such as the
> > + * bonding arp monitor may still use dev_trans_start() on slave
> > + * interfaces such as vlan, macvlan, DSA (or potentially stacked
> > + * combinations of the above). In this case, walk the adjacency lists
> > + * all the way down, hoping that the lower-most device won't have
> > + * NETIF_F_LLTX.
> > + */
>
> I am not sure this assumption holds for virtual devices like veth unless the
> virtual interfaces are updated to modify trans_start, see
> e66e257a5d83 ("veth: Add updating of trans_start")
>
> And not all the virtual interfaces update trans_start iirc.
Agree this hack won't give callers of dev_trans_start() something to chew
in all cases when "dev" is a virtual interface, that's why I said 'stacked'
and not 'virtual'.
prev parent reply other threads:[~2022-07-25 21:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 23:26 [PATCH net] net: dsa: fix bonding with ARP monitoring by updating trans_start manually Vladimir Oltean
2022-07-15 23:52 ` Florian Fainelli
2022-07-16 0:00 ` Jakub Kicinski
2022-07-16 0:14 ` Vladimir Oltean
2022-07-16 0:19 ` Jakub Kicinski
2022-07-16 0:26 ` Vladimir Oltean
2022-07-16 0:55 ` Jakub Kicinski
2022-07-16 13:30 ` Vladimir Oltean
2022-07-16 23:33 ` Jakub Kicinski
2022-07-25 20:31 ` Vladimir Oltean
2022-07-25 20:40 ` Jakub Kicinski
2022-07-25 21:39 ` Jonathan Toppins
2022-07-25 21:53 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725215318.rc7ip2npzl4g6chq@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=b.hutchman@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=jtoppins@redhat.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vfalico@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox