netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Ben Greear <greearb@candelatech.com>
Cc: "Kalle Valo" <kvalo@kernel.org>,
	"Tetsuo Handa" <penguin-kernel@I-love.SAKURA.ne.jp>,
	"Johannes Berg" <johannes@sipsolutions.net>,
	"Toke Høiland-Jørgensen" <toke@kernel.org>,
	"Felix Fietkau" <nbd@nbd.name>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] wifi: mac80211: do not abuse fq.lock in ieee80211_do_stop()
Date: Tue, 26 Jul 2022 14:38:07 -0700	[thread overview]
Message-ID: <20220726143807.68f46fb3@kernel.org> (raw)
In-Reply-To: <df9efa23-e729-d1d0-b66f-248d7ae67c60@candelatech.com>

On Tue, 26 Jul 2022 08:05:12 -0700 Ben Greear wrote:
> >> Since this patch fixes a regression introduced in 5.19-rc7, can this patch go to 5.19-final ?
> >>
> >> syzbot is failing to test linux.git for 12 days due to this regression.
> >> syzbot will fail to bisect new bugs found in the upcoming merge window
> >> if unable to test v5.19 due to this regression.  
> > 
> > I took this to wireless-next as I didn't think there's enough time to
> > get this to v5.19 (and I only heard Linus' -rc8 plans after the fact).
> > So this will be in v5.20-rc1 and I recommend pushing this to a v5.19
> > stable release.  
> 
> Would it be worth reverting the patch that broke things until the first stable 5.19.x
> tree then?  Seems lame to ship an official kernel with a known bug like this.

I cherry-picked the fix across the trees after talking to Kalle and
DaveM. Let's see how that goes...

  reply	other threads:[~2022-07-26 21:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14 12:08 [syzbot] INFO: trying to register non-static key in ieee80211_do_stop syzbot
2022-07-17  2:32 ` [PATCH] wifi: mac80211: initialize fq.lock as early as possible Tetsuo Handa
2022-07-17 12:21   ` [PATCH v2] wifi: mac80211: do not abuse fq.lock in ieee80211_do_stop() Tetsuo Handa
2022-07-18 11:22     ` Toke Høiland-Jørgensen
2022-07-18 12:01     ` Kalle Valo
2022-07-26  6:55       ` Tetsuo Handa
2022-07-26 14:38         ` Kalle Valo
2022-07-26 15:05           ` Ben Greear
2022-07-26 21:38             ` Jakub Kicinski [this message]
2022-07-28 23:00               ` Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220726143807.68f46fb3@kernel.org \
    --to=kuba@kernel.org \
    --cc=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=toke@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).