From: Vladimir Oltean <olteanv@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, andrew@lunn.ch,
vivien.didelot@gmail.com, f.fainelli@gmail.com
Subject: Re: [patch net-next RFC] net: dsa: move port_setup/teardown to be called outside devlink port registered area
Date: Tue, 26 Jul 2022 19:55:20 +0300 [thread overview]
Message-ID: <20220726165520.due75djbddyz4uc4@skbuf> (raw)
In-Reply-To: <YuASl48SzUq/IOrR@nanopsycho> <YuASl48SzUq/IOrR@nanopsycho>
On Tue, Jul 26, 2022 at 06:13:11PM +0200, Jiri Pirko wrote:
> Here it is:
Thanks, this one does apply.
We have the same problem, except now it's with port->region_list
(region_create does list_add_tail, port_register does INIT_LIST_HEAD).
I don't think you need to see this anymore, but anyway, here it is.
[ 4.949727] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000010
[ 5.020395] CPU: 1 PID: 8 Comm: kworker/u4:0 Not tainted 5.19.0-rc7-07010-ga9b9500ffaac-dirty #3397
[ 5.047447] pc : devlink_port_region_create+0x6c/0x150
[ 5.052587] lr : dsa_devlink_port_region_create+0x64/0x90
[ 5.057983] sp : ffff80000c17b8b0
[ 5.132669] Call trace:
[ 5.135109] devlink_port_region_create+0x6c/0x150
[ 5.139899] dsa_devlink_port_region_create+0x64/0x90
[ 5.144946] mv88e6xxx_setup_devlink_regions_port+0x30/0x60
[ 5.150520] mv88e6xxx_port_setup+0x10/0x20
[ 5.154700] dsa_port_devlink_setup+0x60/0x150
[ 5.159141] dsa_register_switch+0x938/0x119c
[ 5.163496] mv88e6xxx_probe+0x714/0x770
[ 5.167416] mdio_probe+0x34/0x70
next prev parent reply other threads:[~2022-07-26 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 12:41 [patch net-next RFC] net: dsa: move port_setup/teardown to be called outside devlink port registered area Jiri Pirko
2022-07-26 13:43 ` Vladimir Oltean
2022-07-26 14:45 ` Jiri Pirko
2022-07-26 15:20 ` Vladimir Oltean
2022-07-26 15:57 ` Jiri Pirko
2022-07-26 16:13 ` Jiri Pirko
2022-07-26 16:55 ` Vladimir Oltean [this message]
2022-07-26 18:27 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726165520.due75djbddyz4uc4@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox