From: Jakub Kicinski <kuba@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: netdev@vger.kernel.org, patches@lists.linux.dev,
kernel test robot <lkp@intel.com>,
Vadim Fedorenko <vadfed@fb.com>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH] ptp: ocp: select CRC16 to fix build error
Date: Tue, 26 Jul 2022 19:56:21 -0700 [thread overview]
Message-ID: <20220726195621.1b023508@kernel.org> (raw)
In-Reply-To: <20220727011213.24274-1-rdunlap@infradead.org>
On Tue, 26 Jul 2022 18:12:13 -0700 Randy Dunlap wrote:
> ptp_ocp.c uses crc16(), so it should select CRC16 to
> prevent a build error:
>
> ERROR: modpost: "crc16" [drivers/ptp/ptp_ocp.ko] undefined!
>
> Fixes: 3c3673bde50c ("ptp: ocp: Add firmware header checks")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Vadim Fedorenko <vadfed@fb.com>
> Cc: Jonathan Lemon <jonathan.lemon@gmail.com>
Jonathan just posted this fix a few hours ago:
https://lore.kernel.org/all/20220726220604.1339972-1-jonathan.lemon@gmail.com/
prev parent reply other threads:[~2022-07-27 2:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 1:12 [PATCH] ptp: ocp: select CRC16 to fix build error Randy Dunlap
2022-07-27 2:56 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726195621.1b023508@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonathan.lemon@gmail.com \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patches@lists.linux.dev \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=vadfed@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).