From: Jakub Kicinski <kuba@kernel.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: Hayes Wang <hayeswang@realtek.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: question on MAC passthrough and multiple devices in r8152
Date: Wed, 27 Jul 2022 09:09:00 -0700 [thread overview]
Message-ID: <20220727090900.75d2b7b8@kernel.org> (raw)
In-Reply-To: <444df45c-ec1d-62a6-eea8-44a0635b2fdf@suse.com>
On Wed, 27 Jul 2022 12:51:44 +0200 Oliver Neukum wrote:
> I am looking at the logic the r8152 driver uses to
> assign a pass through MAC and I do not understand how
> you make sure that it is passed to one device only.
> As far as I can see the MAC comes from an ACPI object,
> hence the driver will happily read it out and assign
> it multiple times. Am I overlooking something?
Just to be sure - have you seen the giant threads on the topic?
IIRC lenovo was sending patches to extend the mechanism, broke
some people's setups and to much teeth grinding we accepted the
somewhat improved patches and moved on. The entire mechanism is
quite poorly designed, we couldn't come up with a better way :(
next prev parent reply other threads:[~2022-07-27 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 10:51 question on MAC passthrough and multiple devices in r8152 Oliver Neukum
2022-07-27 16:09 ` Jakub Kicinski [this message]
2022-07-28 7:59 ` Hayes Wang
2022-07-28 19:19 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220727090900.75d2b7b8@kernel.org \
--to=kuba@kernel.org \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).