* question on MAC passthrough and multiple devices in r8152
@ 2022-07-27 10:51 Oliver Neukum
2022-07-27 16:09 ` Jakub Kicinski
2022-07-28 7:59 ` Hayes Wang
0 siblings, 2 replies; 4+ messages in thread
From: Oliver Neukum @ 2022-07-27 10:51 UTC (permalink / raw)
To: Hayes Wang; +Cc: netdev@vger.kernel.org
Hi,
I am looking at the logic the r8152 driver uses to
assign a pass through MAC and I do not understand how
you make sure that it is passed to one device only.
As far as I can see the MAC comes from an ACPI object,
hence the driver will happily read it out and assign
it multiple times. Am I overlooking something?
Regards
Oliver
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: question on MAC passthrough and multiple devices in r8152
2022-07-27 10:51 question on MAC passthrough and multiple devices in r8152 Oliver Neukum
@ 2022-07-27 16:09 ` Jakub Kicinski
2022-07-28 7:59 ` Hayes Wang
1 sibling, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2022-07-27 16:09 UTC (permalink / raw)
To: Oliver Neukum; +Cc: Hayes Wang, netdev@vger.kernel.org
On Wed, 27 Jul 2022 12:51:44 +0200 Oliver Neukum wrote:
> I am looking at the logic the r8152 driver uses to
> assign a pass through MAC and I do not understand how
> you make sure that it is passed to one device only.
> As far as I can see the MAC comes from an ACPI object,
> hence the driver will happily read it out and assign
> it multiple times. Am I overlooking something?
Just to be sure - have you seen the giant threads on the topic?
IIRC lenovo was sending patches to extend the mechanism, broke
some people's setups and to much teeth grinding we accepted the
somewhat improved patches and moved on. The entire mechanism is
quite poorly designed, we couldn't come up with a better way :(
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: question on MAC passthrough and multiple devices in r8152
2022-07-27 10:51 question on MAC passthrough and multiple devices in r8152 Oliver Neukum
2022-07-27 16:09 ` Jakub Kicinski
@ 2022-07-28 7:59 ` Hayes Wang
2022-07-28 19:19 ` Oliver Neukum
1 sibling, 1 reply; 4+ messages in thread
From: Hayes Wang @ 2022-07-28 7:59 UTC (permalink / raw)
To: Oliver Neukum; +Cc: netdev@vger.kernel.org
Oliver Neukum <oneukum@suse.com>
> Sent: Wednesday, July 27, 2022 6:52 PM
> To: Hayes Wang <hayeswang@realtek.com>
> Cc: netdev@vger.kernel.org
> Subject: question on MAC passthrough and multiple devices in r8152
>
> Hi,
>
> I am looking at the logic the r8152 driver uses to
> assign a pass through MAC and I do not understand how
> you make sure that it is passed to one device only.
> As far as I can see the MAC comes from an ACPI object,
> hence the driver will happily read it out and assign
> it multiple times. Am I overlooking something?
You are right. And, the patches are not submitted by me.
As far as I know, our customers don't care the situation.
They would provide the guide to describe it. Besides, the
feature could be disabled through BIOS.
In addition, the Dell limits the specific devices to
use the feature of MAC passthrough. It could reduce such
situation.
Best Regards,
Hayes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-28 19:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-27 10:51 question on MAC passthrough and multiple devices in r8152 Oliver Neukum
2022-07-27 16:09 ` Jakub Kicinski
2022-07-28 7:59 ` Hayes Wang
2022-07-28 19:19 ` Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).