From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D22CC19F2B for ; Wed, 27 Jul 2022 13:38:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232322AbiG0Nic (ORCPT ); Wed, 27 Jul 2022 09:38:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230410AbiG0Nia (ORCPT ); Wed, 27 Jul 2022 09:38:30 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8E1519029; Wed, 27 Jul 2022 06:38:29 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id z22so21421362edd.6; Wed, 27 Jul 2022 06:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=N+Kho1tTDYMy+feUtLoUrIepxnc5e58P8cS7A/7gF+U=; b=qxLOalOnGgYaNSBiFh7kG611YZYBypvahjLD7H1hwxpmxyssGZ1k2CisnikXq7XsLG N41BKOmt4wK76lryxMWoSpzMK9BIrvFX6nrrtTzZw2RXKMbsilE6/ilIrKSMVCsl1tAQ FULDxEcIGAbvZhrcbK3bBczD45KB0mtMiun56LjdTtQkFdFX1fzK+J3AI9a1NQmpszvm 3WsI4DSQ+t9EU7CL2uEUHduuk8Bh8uo5GUXNKE6CSKxrbTivW2tZHoJ9FRPYFH3Uv86b SIdJY6L+UQegZ4uyqiqNtGPsd7ovg44+S/QfRCqOkLDhmznl/9GZu21QGsaGbTOO33Jm OFeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=N+Kho1tTDYMy+feUtLoUrIepxnc5e58P8cS7A/7gF+U=; b=vQpSgDBrxCPBWn+DJ0KCHze18myczUDDEIJy0VMM/DsDld8BOq81txzaHo+4rnGXXM gbadsSMkXapkMzByuHriJtP28p+R6lI7VfbFVEw70zgpkWHXY15ehcSTyOmyO08ZIqGA iuku+SYAL6wSF0x5lwH+bcUQHnHgUHRjf31zJZVAzrNTiQgyQ+8Y2dxFnYTRfC8J8BE1 mGqU5gvpPC/pCVWs/6DdlLCgaH3tuUoELckoolKyfDgMiA6awkBaDsiG5wTsOIkkKQF3 FamU4th5gZH5356rR8R+If97X91CZcfeW174x8wfMJyW04qq+loPspAqZDiUNbmJjSh7 eTYQ== X-Gm-Message-State: AJIora/fi1YCHjH62td51+0XF2tZV3pRV4I0l2GxuuNpDfHQPlg/oSHl 12//Wpo8a5CFIG5gI3A3Kp0= X-Google-Smtp-Source: AGRyM1tZdX7DcKsI0OH23LMM8bUt8j1r6SKxeLv0A5Vc723Jp1Ef5b9L3U3LBQ7vPjvnF4yyq0Tmdw== X-Received: by 2002:a05:6402:3282:b0:43b:e650:4352 with SMTP id f2-20020a056402328200b0043be6504352mr18381276eda.376.1658929108106; Wed, 27 Jul 2022 06:38:28 -0700 (PDT) Received: from skbuf ([188.25.231.115]) by smtp.gmail.com with ESMTPSA id g21-20020aa7c855000000b0043bd753174esm7940248edt.27.2022.07.27.06.38.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 06:38:27 -0700 (PDT) Date: Wed, 27 Jul 2022 16:38:24 +0300 From: Vladimir Oltean To: Marek =?utf-8?B?QmVow7pu?= Cc: "Russell King (Oracle)" , Andrew Lunn , Heiner Kallweit , Alexandre Belloni , Alvin =?utf-8?Q?=C5=A0ipraga?= , Andy Shevchenko , Claudiu Manoil , Daniel Scally , "David S. Miller" , DENG Qingfang , Eric Dumazet , Florian Fainelli , George McCollister , Greg Kroah-Hartman , Hauke Mehrtens , Heikki Krogerus , Jakub Kicinski , Kurt Kanzenbach , Landen Chao , Linus Walleij , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , "Rafael J. Wysocki" , Sakari Ailus , Sean Wang , UNGLinuxDriver@microchip.com, Vivien Didelot , Woojung Huh Subject: Re: [PATCH net-next 0/6] net: dsa: always use phylink Message-ID: <20220727133824.ymedhfhrggietmpj@skbuf> References: <20220727110051.2df82bf6@dellmb> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220727110051.2df82bf6@dellmb> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello Marek, On Wed, Jul 27, 2022 at 11:00:51AM +0200, Marek Behún wrote: > Dear Vladimir, > > am I understanding correctly that your main objection to this series is > that it may break other drivers? Yes, but I'm not saying this in a way that tries to make it impossible to make progress. But rather, I've identified 8 drivers which may lack complete device tree descriptions: https://patchwork.kernel.org/project/netdevbpf/patch/20220723164635.1621911-1-vladimir.oltean@nxp.com/ Simply put, I have no indication that the changes presented here are a step in the right direction for the remaining 7 drivers. Each and every single one of them needs to be studied and discussed separately; the discussion has already started for some. > Do you think it would be okay if I changed it so that only mv88e6xxx > driver would ask for phylink for CPU/DSA ports? It would be a good start, yes. What I could do is I could move my validation logic from the patch linked above into dsa_port_link_register_of(). Running that logic would let DSA know which properties are missing. Then, for drivers that don't enforce validation, we could add new dsa_switch_ops that separately ask the driver what phy-mode to use (if missing) and what speed/duplex to use (if missing). Drivers can use whatever heuristic is appropriate for their deployments to respond to this. If the phy-mode and speed/duplex are finally resolved, DSA can create a software_node and register with phylink that way. Otherwise, DSA will continue to do what it does today, i.e. skip phylink registration. How does that sound?