From: Jakub Kicinski <kuba@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: borisp@nvidia.com, john.fastabend@gmail.com, davem@davemloft.net,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] tls: rx: Fix unsigned comparison with less than zero
Date: Wed, 27 Jul 2022 19:05:11 -0700 [thread overview]
Message-ID: <20220727190511.08f4fe0c@kernel.org> (raw)
In-Reply-To: <20220728011025.10865-1-yang.lee@linux.alibaba.com>
On Thu, 28 Jul 2022 09:10:25 +0800 Yang Li wrote:
> struct tls_strparser *strp = (struct tls_strparser *)desc->arg.data;
> - size_t sz, len, chunk;
> + int sz;
> + size_t len, chunk;
> struct sk_buff *skb;
> skb_frag_t *frag;
Thanks for the fix, please keep the sorting of the variable lines from
longest to shortest. "int sz;" should be the last variable declaration
line and "size_t len, chunk;" goes after the skb.
prev parent reply other threads:[~2022-07-28 2:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 1:10 [PATCH -next] tls: rx: Fix unsigned comparison with less than zero Yang Li
2022-07-28 2:05 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220727190511.08f4fe0c@kernel.org \
--to=kuba@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).