From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC31C3F6B0 for ; Thu, 28 Jul 2022 17:40:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231761AbiG1Rkd (ORCPT ); Thu, 28 Jul 2022 13:40:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbiG1Rkc (ORCPT ); Thu, 28 Jul 2022 13:40:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5841A743DF; Thu, 28 Jul 2022 10:40:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E78DE61D67; Thu, 28 Jul 2022 17:40:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA964C433C1; Thu, 28 Jul 2022 17:40:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659030030; bh=NAxXDnSczzozx1WrRkURk3q4OYlqYARSYkqGoCWcuxQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ayTTvDzcHZd5mgPzNrw1FgMXC4UBpKIDe2fVqk0DANBhvaUJ488sp+rg4sK8wLpcP zncZSmDEY+WIxZjY9OLYwJEekOzTp/C70dnh/calXPZpxFCaiCirSpphI8N9TnfnR2 dShpP4txufRLq6HKWKZxOrlAK24SAw/XA4lJ/CuGhQWsE7HAJ/zgTtmBMg0IMf3ZE2 oNhTtiAH1bYv/OTaa0ii++3OEA8T8PtMSOm8qADUcz/uDiDe2SN0s51KBc4y1uFnzW kcK6MDIWgVnrBHNeBzJAddW4mCRBDhLFW5xnTbTZFsIJvwXGrKPP6ng9iQZoYQNEf6 QxwLgnECwvZ9g== Date: Thu, 28 Jul 2022 10:40:28 -0700 From: Jakub Kicinski To: Martin KaFai Lau Cc: Stanislav Fomichev , bpf@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , David Miller , Eric Dumazet , kernel-team@fb.com, Paolo Abeni Subject: Re: [PATCH bpf-next 02/14] bpf: net: Avoid sock_setsockopt() taking sk lock when called from bpf Message-ID: <20220728104028.04cd6842@kernel.org> In-Reply-To: <20220728172004.6mpkycl52sszuudc@kafai-mbp.dhcp.thefacebook.com> References: <20220727060909.2371812-1-kafai@fb.com> <20220727183700.iczavo77o6ubxbwm@kafai-mbp.dhcp.thefacebook.com> <20220727212133.3uvpew67rzha6rzp@kafai-mbp.dhcp.thefacebook.com> <20220728004546.6n42isdvyg65vuke@kafai-mbp.dhcp.thefacebook.com> <20220727184903.4d24a00a@kernel.org> <20220728163104.usdkmsxjyqwaitxu@kafai-mbp.dhcp.thefacebook.com> <20220728095629.6109f78c@kernel.org> <20220728172004.6mpkycl52sszuudc@kafai-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 28 Jul 2022 10:20:04 -0700 Martin KaFai Lau wrote: > > Which is what I believe Stan was proposing. > Yeah, I think I read the 'vote against @in_bpf' in the other way. :) My bad, I didn't read the proposal in sufficient detail to realize the helper is called the same thing as the bit :D