netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guillaume Nault <gnault@redhat.com>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com, stephen@networkplumber.org
Subject: Re: [PATCH iproute-next v3 3/3] f_flower: Introduce PPPoE support
Date: Thu, 28 Jul 2022 13:18:27 +0200	[thread overview]
Message-ID: <20220728111827.GF18015@pc-4.home> (raw)
In-Reply-To: <20220728110117.492855-4-wojciech.drewek@intel.com>

On Thu, Jul 28, 2022 at 01:01:17PM +0200, Wojciech Drewek wrote:
> Introduce PPPoE specific fields in tc-flower:
> - session id (16 bits)
> - ppp protocol (16 bits)
> Those fields can be provided only when protocol was set to
> ETH_P_PPP_SES. ppp_proto works similar to vlan_ethtype, i.e.
> ppp_proto overwrites eth_type. Thanks to that, fields from
> encapsulated protocols (such as src_ip) can be specified.

Acked-by: Guillaume Nault <gnault@redhat.com>

Thanks for working on PPP/PPPoE!


  reply	other threads:[~2022-07-28 11:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 11:01 [PATCH iproute-next v3 0/3] PPPoE support in tc-flower Wojciech Drewek
2022-07-28 11:01 ` [PATCH iproute-next v3 1/3] lib: refactor ll_proto functions Wojciech Drewek
2022-07-28 11:16   ` Guillaume Nault
2022-07-28 11:01 ` [PATCH iproute-next v3 2/3] lib: Introduce ppp protocols Wojciech Drewek
2022-07-28 11:17   ` Guillaume Nault
2022-07-28 22:22   ` David Ahern
2022-07-29  8:59     ` Drewek, Wojciech
2022-07-29 15:00       ` David Ahern
2022-07-28 11:01 ` [PATCH iproute-next v3 3/3] f_flower: Introduce PPPoE support Wojciech Drewek
2022-07-28 11:18   ` Guillaume Nault [this message]
2022-07-28 11:21     ` Drewek, Wojciech

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220728111827.GF18015@pc-4.home \
    --to=gnault@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=wojciech.drewek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).