From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Mark Greer" <mgreer@animalcreek.com>,
"Kalle Valo" <kvalo@kernel.org>,
"Adham Abozaeid" <adham.abozaeid@microchip.com>,
"Tony Lindgren" <tony@atomide.com>,
devicetree@vger.kernel.org,
"Jérôme Pouiller" <jerome.pouiller@silabs.com>,
linux-wireless@vger.kernel.org, "Paolo Abeni" <pabeni@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Ajay Singh" <ajay.kathat@microchip.com>
Subject: Re: [PATCH 2/2] dt-bindings: wireless: use spi-peripheral-props.yaml
Date: Thu, 28 Jul 2022 09:18:24 -0600 [thread overview]
Message-ID: <20220728151824.GA901389-robh@kernel.org> (raw)
In-Reply-To: <20220727164130.385411-2-krzysztof.kozlowski@linaro.org>
On Wed, 27 Jul 2022 18:41:30 +0200, Krzysztof Kozlowski wrote:
> Instead of listing directly properties typical for SPI peripherals,
> reference the spi-peripheral-props.yaml schema. This allows using all
> properties typical for SPI-connected devices, even these which device
> bindings author did not tried yet.
>
> Remove the spi-* properties which now come via spi-peripheral-props.yaml
> schema, except for the cases when device schema adds some constraints
> like maximum frequency.
>
> While changing additionalProperties->unevaluatedProperties, put it in
> typical place, just before example DTS.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Technically, this depends on [1] merged to SPI tree, if we want to
> preserve existing behavior of not allowing SPI CPHA and CPOL in each of
> schemas in this patch.
>
> If this patch comes independently via different tree, the SPI CPHA and
> CPOL will be allowed for brief period of time, before [1] is merged.
> This will not have negative impact, just DT schema checks will be
> loosened for that period.
>
> [1] https://lore.kernel.org/all/20220722191539.90641-2-krzysztof.kozlowski@linaro.org/
> ---
> .../net/wireless/microchip,wilc1000.yaml | 7 ++--
> .../bindings/net/wireless/silabs,wfx.yaml | 15 +++------
> .../bindings/net/wireless/ti,wlcore.yaml | 32 +++++++++----------
> 3 files changed, 25 insertions(+), 29 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-07-28 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 16:41 [PATCH 1/2] dt-bindings: nfc: use spi-peripheral-props.yaml Krzysztof Kozlowski
2022-07-27 16:41 ` [PATCH 2/2] dt-bindings: wireless: " Krzysztof Kozlowski
2022-07-28 15:18 ` Rob Herring [this message]
2022-08-09 5:58 ` Kalle Valo
2022-07-28 15:18 ` [PATCH 1/2] dt-bindings: nfc: " Rob Herring
2022-07-28 16:31 ` Krzysztof Kozlowski
2022-07-29 5:27 ` Jakub Kicinski
2022-07-29 5:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220728151824.GA901389-robh@kernel.org \
--to=robh@kernel.org \
--cc=adham.abozaeid@microchip.com \
--cc=ajay.kathat@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jerome.pouiller@silabs.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).