From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19194C19F29 for ; Thu, 28 Jul 2022 15:18:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231600AbiG1PSb (ORCPT ); Thu, 28 Jul 2022 11:18:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231588AbiG1PS3 (ORCPT ); Thu, 28 Jul 2022 11:18:29 -0400 Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C8144E872; Thu, 28 Jul 2022 08:18:28 -0700 (PDT) Received: by mail-il1-f179.google.com with SMTP id g18so1087580ilk.4; Thu, 28 Jul 2022 08:18:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=Ls3JiwmJiYnShJa3Bd4qG+DnJ7AXD6lVMWiDMb9zReM=; b=dVGnYNa4lVNrmpnAFZYiGEZBfYkC3HCWW6Ko2N9jUKhtzk/htubATlKZYHRyCaEx1V +sU+93hpM5dHADlp+0hrphEDWe5lHyBu1rMoWhIkD4V6VD37kJhUIaIAPH8LdClgQuKe y8/BV6fIlZMN7GargEtnU7TWR22lw0WUHGoZ8T+AgWW1Sh+mFLD4oGICyapcJT9rvYJa b6EtJtbBny8i3luj7NQHKV6opvDmop1Qlh2kev0wXhLJK1+w8TjqK7Y+SoN0u4Shj0Bv pyd2FZVyF4nfrCS3aMRWFDof1/xhMfMo3x/eQGOxzNhVaBNQFZC87FnDeTUF6oY1e7/w 2ERQ== X-Gm-Message-State: AJIora92925JKPBmsJCJ6LACa7PFv6sXmCvlwe+djJYBpEGTY0JRbR2m 1nGsM6OmshV8wm9c6LJl6w== X-Google-Smtp-Source: AGRyM1s9jv0cpkUY/QpbAsgHZc/CwhX9Bqdm6Ubf0jkIS51YGAV/oOwEBjmvjlqz1WZnDg5UOb3LaA== X-Received: by 2002:a05:6e02:1181:b0:2dd:bd7a:26c5 with SMTP id y1-20020a056e02118100b002ddbd7a26c5mr3673515ili.8.1659021507770; Thu, 28 Jul 2022 08:18:27 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id q8-20020a02a988000000b0033f22c2e5b3sm477024jam.98.2022.07.28.08.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 08:18:27 -0700 (PDT) Received: (nullmailer pid 901441 invoked by uid 1000); Thu, 28 Jul 2022 15:18:24 -0000 Date: Thu, 28 Jul 2022 09:18:24 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Mark Greer , Kalle Valo , Adham Abozaeid , Tony Lindgren , devicetree@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Pouiller , linux-wireless@vger.kernel.org, Paolo Abeni , Jakub Kicinski , Rob Herring , Eric Dumazet , Ajay Singh Subject: Re: [PATCH 2/2] dt-bindings: wireless: use spi-peripheral-props.yaml Message-ID: <20220728151824.GA901389-robh@kernel.org> References: <20220727164130.385411-1-krzysztof.kozlowski@linaro.org> <20220727164130.385411-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220727164130.385411-2-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 27 Jul 2022 18:41:30 +0200, Krzysztof Kozlowski wrote: > Instead of listing directly properties typical for SPI peripherals, > reference the spi-peripheral-props.yaml schema. This allows using all > properties typical for SPI-connected devices, even these which device > bindings author did not tried yet. > > Remove the spi-* properties which now come via spi-peripheral-props.yaml > schema, except for the cases when device schema adds some constraints > like maximum frequency. > > While changing additionalProperties->unevaluatedProperties, put it in > typical place, just before example DTS. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Technically, this depends on [1] merged to SPI tree, if we want to > preserve existing behavior of not allowing SPI CPHA and CPOL in each of > schemas in this patch. > > If this patch comes independently via different tree, the SPI CPHA and > CPOL will be allowed for brief period of time, before [1] is merged. > This will not have negative impact, just DT schema checks will be > loosened for that period. > > [1] https://lore.kernel.org/all/20220722191539.90641-2-krzysztof.kozlowski@linaro.org/ > --- > .../net/wireless/microchip,wilc1000.yaml | 7 ++-- > .../bindings/net/wireless/silabs,wfx.yaml | 15 +++------ > .../bindings/net/wireless/ti,wlcore.yaml | 32 +++++++++---------- > 3 files changed, 25 insertions(+), 29 deletions(-) > Acked-by: Rob Herring